home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.76k stars 30.47k forks source link

Lutron integration sends device press command to RadioRa2 hub to activate scene but a device release command is requred. #127810

Open sgawne opened 2 weeks ago

sgawne commented 2 weeks ago

The problem

I have several RRD-H6BRL hybrid wall see touch controllers are programmed for various scenes. The integration recognizes them and gives scene components, but when activating the scene it is using the Press (3) command rather than a Release (4) command. The Press command is ignored, only a release command is acted on.

What version of Home Assistant Core has the issue?

core-2024.10.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Lutron

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

This is a message sent by HA. It has no reaction from the Lutron hub
~DEVICE,11,5,3

This is a release message sent by the Lutron Home+ app showing what happens if a release message is sent.

~DEVICE,11,5,4
~DEVICE,11,85,9,1
~OUTPUT,10,1,80.00
~OUTPUT,10,29,8
~OUTPUT,10,30,1,80.00
~OUTPUT,14,1,80.00
~OUTPUT,14,29,8
~OUTPUT,14,30,1,80.00

Additional information

I am running RadioRa2 12.0.1

home-assistant[bot] commented 2 weeks ago

Hey there @cdheiser, @wilburcforce, mind taking a look at this issue as it has been labeled with an integration (lutron) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `lutron` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign lutron` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


lutron documentation lutron source (message by IssueLinks)

sgawne commented 2 weeks ago

The issue is in scene.py. Line 54 reads: self._lutron_device.press()

it should be self.lutron_device.release(). Or send both a press and a release. I have temporarily hacked my docker container to do this and it activates scenes correctly.

Just of note, before this I had updated the my lutron hub to 12.10 and reloaded everything but it had no effect.

cdheiser commented 2 weeks ago

Can you post your DbInfoXML.xml ? This code has been this way for about 6 years and I've never encountered a scene that requires the button to be released. (Not that they don't exist). But we need the XML to know how to properly decode such configurations.

On Mon, Oct 7, 2024 at 1:42 PM sgawne @.***> wrote:

The issue is in scene.py. Line 54 reads: self._lutron_device.press()

it should be self.lutron_device.release(). Or send both a press and a release. I have temporarily hacked my docker container to do this and it activates scenes correctly.

Just of note, before this I had updated the my lutron hub to 12.10 and reloaded everything but it had no effect.

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/127810#issuecomment-2397854226, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQARWVRQ6BJYLXCBMGTFTDZ2LWZXAVCNFSM6AAAAABPPZP2W2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJXHA2TIMRSGY . You are receiving this because you were mentioned.Message ID: @.***>

jongawne commented 2 weeks ago

Keypad scenes appear not to IF the advanced option of saving settings on keypress hold is enabled in the lutron software. From another thread: https://community.home-assistant.io/t/lutron-radiora2-not-seeing-seetouch-keypad-button-presses/593687/20

sgawne commented 2 weeks ago

My keypad scenes are set for saving settings with the keypress hold. I just disabled the ability to save scenes from the keypad for a test and just sending press works. So it seems if you have configured the ability to save/update scenes from the keypad you need to send a release command rather than the push.

sgawne commented 2 weeks ago

Here is a difference between my 2 xml files.. It actually tells you what it is expecting

sgawne commented 2 weeks ago

now to add the correct image DbXmlInfo_compare

sgawne commented 2 weeks ago

I attached a file that shows before and after disabling of the ability to save scenes: dbinfo_compare.txt

cdheiser commented 2 weeks ago

PR Created: https://github.com/home-assistant/core/pull/127899

On Mon, Oct 7, 2024 at 2:53 PM sgawne @.***> wrote:

I attached a file that shows before and after disabling of the ability to save scenes: dbinfo_compare.txt https://github.com/user-attachments/files/17284888/dbinfo_compare.txt

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/127810#issuecomment-2397984673, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQARWXV5H2OPXOLTQSKCTTZ2L7GZAVCNFSM6AAAAABPPZP2W2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJXHE4DINRXGM . You are receiving this because you were mentioned.Message ID: @.***>