Help wanted: fix missing translation strings

epenet commented 1 month ago

The problem

As a developper, it's very easy to forget adding all expected translation keys into strings.json I am working on catching this within the regular test routines (see https://github.com/home-assistant/core/pull/127787)

If you would like to help, take a look at the resulting failures and see if you can add/fix.

It is possible to do a search through the code for # Remove when translations fixed eg.

@pytest.mark.parametrize(  # Remove when translations fixed
    "ignore_translations",
    ["component.flume.config.error.invalid_auth"],
)

[x] emoncms options.error.failure
[x] flume config.error.invalid_auth / config.error.cannot_connect / config.abort.reauth_successful #130631
[x] generic config.error.Some message #130672
[x] google_assistant_sdk config.abort.single_instance_allowed #130632
[x] homeworks config.abort.reconfigure_successful #129824
[x] honeywell config.abort.reauth_successful #129823
[x] hvv_departures options.error.cannot_connect / options.error.invalid_auth #130634
[x] hydrawise config.error.invalid_auth #129834
[x] jewish_calendar config.abort.reconfigure_successful #129822
[x] landisgyr_heat_meter config.error.cannot_connect #129831
[x] lg_netcast config.abort.invalid_host #130635
[x] madvr config.abort.set_up_new_device #130656
[x] nina options.error.unknown #127908
[x] ollama config.abort.download_failed https://github.com/home-assistant/core/pull/130164
[x] onewire options.abort.No configurable devices found. #130673
[x] ovo_energy config.error.authorization_error / config.error.connection_error / config.abort.reauth_successful #129833
[x] philips_js config.abort.pairing_failure
[x] srp_energy config.abort.unknown #130540
[x] subaru config.abort.two_factor_request_failed https://github.com/home-assistant/core/pull/130486/files
[x] toon config.abort.connection_error #130655
[x] tradfri config.error.invalid_security_code #130654
[x] utility_meter config.error.tariffs_not_unique #130652
[x] vilfo config.error.wrong_host #130650

mib1185 commented 1 month ago

These are all open ones (without a pending PR)

...

Edit: converted to task list in the description

epenet commented 1 month ago

These are all open ones (without a pending PR)

Thanks, I've converted to a task list in the description

mib1185 commented 1 month ago

we have some integrations (eq. generic and webmin, properly much more) which redirects possible connection errors direct into the errors dict to the async_show_form, those they can have unexpected or unforeseen error values, which can't be translated :thinking: Should we adjust the tests in this case, so they test only expected errors? Or do we've the possibility to work with placeholders also for errors in flow forms?

epenet commented 1 month ago

we have some integrations (eq. generic and webmin, properly much more) which redirects possible connection errors direct into the errors dict to the async_show_form, those they can have unexpected or unforeseen error values, which can't be translated 🤔 Should we adjust the tests in this case, so they test only expected errors? Or do we've the possibility to work with placeholders also for errors in flow forms?

Might be worth confirming with a core member... I think we normally use "unknown" and log the full details

gjohansson-ST commented 1 month ago

I think we normally use "unknown" and log the full details

Like that yes, we can only translate known errors e.g. there is no placeholders or such.

epenet commented 1 month ago

I've updated the task list to remove (at least temporarily) the data strings, and add the latest PRs from @j4n-e4t

j4n-e4t commented 1 month ago

@epenet Do you have a way to get all components that still have the ignore_translations rule in the config_flow tests? Should I go through them and file a PR removing them for the merged ones? I found quite some components still having such rule in place, even if the translation is added correctly. Also my merged PRs from yesterday.

epenet commented 1 month ago

@epenet Do you have a way to get all components that still have the ignore_translations rule in the config_flow tests? Should I go through them and file a PR removing them for the merged ones? I found quite some components still having such rule in place, even if the translation is added correctly. Also my merged PRs from yesterday.

I've opened https://github.com/home-assistant/core/pull/128441 to remove them all There was a gap in the previous detection logic