home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.38k stars 30.64k forks source link

Support hybrid devices in ViCare integration #128242

Closed noseshimself closed 3 weeks ago

noseshimself commented 3 weeks ago

The problem

"In general every vicare system seems to be a unicorn 🦄. By now, we just try to map the devices that are in the api by type. Hybrids are not considered. So if the api show the devices as an own unit you should see it."

The diagnostic file shows that all relevant information pertaining to all heat sources is provided via ViCare API.

See attached configuration file: https://api.viessmann.com/iot/v1/features/installations/#######/gateways/################/devices/0/features/heating.burners returns an array consisting of one burner and is offering related data (burner starts...) and https://api.viessmann.com/iot/v1/features/installations/#######/gateways/################/devices/0/features/heating.compressors is listing all the heat pumps (and I know at least one installation with three different heat pumps shown there...).

It would be nice to retrieve https://api.viessmann.com/iot/v1/features/installations/#######/gateways/################/devices/0/features/device.messages.errors.raw even if it only logged (although a text sensor "last_error" would be even more helpful).

The data points are leaving me speechless. It seems to be possible to request that individual heating circuits can be used for individual heating modes (e.g. "heating is optional in winter" --> set the heat pump to dhwAndHeating but the burners to dhw whatever this is good for) using the API. It might be worth adding plausibility checks across the data returned. [Yes -- I used the ViCare integration to diagnose what happened when my heating did not react too well to being set to "fixed".]

What version of Home Assistant Core has the issue?

core-2024.10.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

ViCare

Link to integration documentation on our website

https://www.home-assistant.io/integrations/vicare

Diagnostics information

https://github.com/user-attachments/files/17348079/config_entry-vicare-98e7148db7bf163fc7c57b56b369fe63.json

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 3 weeks ago

Hey there @cfenner, mind taking a look at this issue as it has been labeled with an integration (vicare) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `vicare` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign vicare` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


vicare documentation vicare source (message by IssueLinks)

CFenner commented 3 weeks ago

Unfortunately, your diagnostics show only one device that has nearly every feature. This is not implemented in the vicare library https://github.com/openviess/PyViCare.

Please open an issue there first, so we can implement some kind of hybrid device. I will close the issue till that is done.

CFenner commented 3 weeks ago

@home-assistant rename Support hybrid devices in ViCare integration

CFenner commented 3 weeks ago

@home-assistant close