History Stats Sensor creates wrong data

Loader23 commented 1 month ago

The problem

Hi, my history stats sensor is not working correctly. Iam having this Issue since 2 Years and could work around it with an old custom integration of history stats. Now the HA Log says: _TIME_HOURS was used from historystats, this is a deprecated constant which will be removed in HA Core 2025.1 So I thought it would have been fixed by now, but thats not the case:

History

As soon as I activate the Switch it goes from 0 to over 400.000.

What version of Home Assistant Core has the issue?

2024.10.2

What was the last working version of Home Assistant Core?

June, 2022

What type of installation are you running?

Home Assistant Container

Integration causing the issue

History Stats

Link to integration documentation on our website

https://www.home-assistant.io/integrations/history_stats/

Diagnostics information

No response

Example YAML snippet

sensor:
  - platform: history_stats
    name: Test History
    entity_id: switch.stecker_1
    state: 'on'
    type: time
    start: '{{ 0 }}'
    end: '{{ now() }}'

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 1 month ago

history_stats documentation history_stats source

turbobas commented 1 month ago

I have the same problem after upgrading to 2024.10.2

DoGithDo commented 2 weeks ago

After some experimenting with my own configuration, this seems to happen:

There is a start date of the period, in above example start: '{{ 0 }}' (= Stats Start)
There is a date, when the source sensor of the history stats sensor was added (= Source Start). The error happens as follows:
The time period from Stats Start to Source Start is added, in case Stats Start is before Source Start. In above mentioned error, the 480'000 h (= 54.8 years) correspond to the period from Stats Start ( start: '{{ 0 }}') = 1/1/1970 to Source Start. To test, set start: '{{ }}' to a value after Stats Start. In my case, I added the source sensor on 11-05. This produces correct behavior (Stats Start > Source Start): start: "{{ now().replace(month=11, day=6, hour=0, minute=0, second=0, microsecond=0) }}" This produces wrong behavior (Stats Start < Source Start): start: "{{ now().replace(month=1, day=1, hour=0, minute=0, second=0, microsecond=0) }}" The problem and the solution was already described here: https://community.home-assistant.io/t/history-stats-sensor-creates-wrong-data/476466/6 According to this solution, this change should fix the error in data.py (https://github.com/home-assistant/core/tree/dev/homeassistant/components/history_stats): previous_state_matches = ( self._history_current_period and self._history_current_period[0].state in self._entity_states and start_timestamp > self._history_current_period[0].last_changed.timestamp() # fix first period )

DoGithDo commented 2 weeks ago

@cdce8p history_stats has no Integration Owner. I am missing knowledge to do it myself. Something for you?

karwosts commented 6 days ago

I believe this will be fixed by https://github.com/home-assistant/core/pull/126271

home-assistant / core