home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.79k stars 30.49k forks source link

Groups: Broken grammar in several issues strings, room for improving the details #129054

Open NoRi2909 opened 2 days ago

NoRi2909 commented 2 days ago

The problem

Repair messages for group sensors contain several grammar bugs. Here just two I was able to trigger easily:

Screenshot 2024-10-23 22 16 55

First of all the correct term to use is found here:

https://github.com/home-assistant/core/blob/6ee6a8a74fa1542f3cae532b4c893a60bc62df04/homeassistant/components/group/strings.json#L107

Below almost all strings have broken grammar in English and are in need of a makeover:

https://github.com/home-assistant/core/blob/6ee6a8a74fa1542f3cae532b4c893a60bc62df04/homeassistant/components/group/strings.json#L284-L302

Should be

  Units of measurement are not correct
  Unit of measurement is not correct
  Device classes are not correct
  State classes are not correct

In the explanations correct all occurrences of "unit of measurements" to "units of measurement" or "unit of measurement" (depending on the "are" or "is" that follows).

And have a good look over the rest of the wording, I think there is room for improvement, too.

What version of Home Assistant Core has the issue?

2024.10.3

home-assistant[bot] commented 1 day ago

Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (group) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `group` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign group` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


group documentation group source (message by IssueLinks)