[Jewish Calendar] Issur Melacha incorrect for 3 day holiday

[Abba-]

The problem

This past sukkot Holiday, both weekends were '3 day holidays'. (Oct 16-19 & Oct 23-26). This means that the Sabbath connected to a holiday (which is 2 days). The sensor 'Issur Melacha in effect' should be true from Wed night (the start of the holiday) through Sat night (the end of Sabbath).

However, the Issur Melacha sensor went false for the 2nd day of the holiday (i.e. Thursday) and then went back true Friday afternoon.

Ive attached a few screenshots below.

What version of Home Assistant Core has the issue?

core-2024.10.4

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Jewish Calendar

Link to integration documentation on our website

https://www.home-assistant.io/integrations/jewish_calendar/

Diagnostics information

Notably, the holiday sensor skipped Simcha Torah (the expected value for Thursday). Unfortunately I cant confirm what it was the week before.

Issur Melacha history. (18 candles, 60 Havdalah)

Some other relevant sensor history:

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

[home-assistant[bot]]

Hey there @tsvi, mind taking a look at this issue as it has been labeled with an integration (jewish_calendar) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of `jewish_calendar` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign jewish_calendar` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

---

jewish_calendar documentation jewish_calendar source _{^{(message by IssueLinks)}}

[tsvi]

Looks like diaspora is set to false. Unfortunately at the moment it's not easy to find the value of this configuration (unless you don't mind grepping the .storage JSON files). In 2024.11 there's an upcoming fix to allow reconfiguration. I suggest waiting for it and confirming that diaspora is set to off. If diaspora is set to on, this is a real bug.

[tsvi]

To check the current value, look in the /config/.storage/core.config_entries for the value of the diaspora key. It should be true outside of Israel.

[Abba-]

Yes it's false. (Also FWIW my friend has a similar integration with same issue, if hebcal config is root cause.)

Also if I can ask, why is this an issue now? Have had regular Yom Tovs before with no issue...

{ "created_at": "1970-01-01T00:00:00+00:00", "data": { "diaspora": false, "language": "english", "location": { "latitude": "longitude": }, "elevation": 0, "time_zone": "America/New_York", "latitude": "longitude": }, "discovery_keys": {}, "disabled_by": null, "domain": "jewish_calendar", "entry_id": "a2553bccc07593e42af91ec973112345", "minor_version": 1, "modified_at": "1970-01-01T00:00:00+00:00", "options": { "candle_lighting_minutes_before_sunset": 18, "havdalah_minutes_after_sunset": 60 }, "pref_disable_new_entities": false, "pref_disable_polling": false, "source": "user", "title": "Jewish Calendar", "unique_id": null, "version": 1 },

[tsvi]

a. hebcal is a completely different integration. It relies on pulling information from a third-party site. The Jewish calendar integration on the other hand does all the calculations on the device based on the time/date/location. So the issue might be the same, but completely unrelated. b. Lately, the Jewish calendar integration has moved to the config flow allowing it to be configured from the UI. How did that upgrade happen for you? Did you remove the original YAML? Do you still have it? I wonder if the upgrade didn't go smoothly.