home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.91k stars 30.98k forks source link

Cannot adjust temperature in Intergas InComfort/Intouch Lan2RF gateway #129487

Closed webpatrick closed 3 weeks ago

webpatrick commented 3 weeks ago

The problem

Error occurs when adjusting the thermostat

Logger: homeassistant
Bron: components/incomfort/water_heater.py:63
Eerst voorgekomen: 10:59:32 (61 gebeurtenissen)
Laatst gelogd: 11:29:53

Error doing job: Task exception was never retrieved (None)
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 258, in _handle_refresh_interval
    await self._async_refresh(log_failures=True, scheduled=True)
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 453, in _async_refresh
    self.async_update_listeners()
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 168, in async_update_listeners
    update_callback()
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 533, in _handle_coordinator_update
    self.async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1005, in async_write_ha_state
    self._async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1130, in _async_write_ha_state
    self.__async_calculate_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1069, in __async_calculate_state
    if state_attributes := self.state_attributes:
                           ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/water_heater/__init__.py", line 227, in state_attributes
    self.current_temperature,
    ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/incomfort/water_heater.py", line 63, in current_temperature
    return max(self._heater.heater_temp, self._heater.tap_temp)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: '>' not supported between instances of 'NoneType' and 'float'

What version of Home Assistant Core has the issue?

2024.10.4

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

InComfort

Link to integration documentation on our website

https://www.home-assistant.io/integrations/incomfort/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 3 weeks ago

Hey there @jbouwh, mind taking a look at this issue as it has been labeled with an integration (incomfort) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `incomfort` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign incomfort` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


incomfort documentation incomfort source (message by IssueLinks)

jbouwh commented 3 weeks ago

PR #129496 addresses the case that the water heater returns a None value for heater_temp or tap_temp. So that should stop the error messages you are seeing. So let's see if this addresses the issue. Not sure if it solves it though. My question: Is this incidental, or did it work correctly before?

webpatrick commented 3 weeks ago

My question: Is this incidental, or did it work correctly before?

I just start using this integration, so I have no history.

jbouwh commented 3 weeks ago

If you can install the beta, you could test again with the fix. You can also wait till coming coming release (next Wednesday).

webpatrick commented 3 weeks ago

If you can install the beta, you could test again with the fix. You can also wait till coming coming release (next Wednesday).

v2024.11.0b1 fixed this issue for me 👍