home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.48k stars 30.69k forks source link

New integration Missing many sensors #129601

Open bschatzow opened 6 days ago

bschatzow commented 6 days ago

The problem

Many useful sensors that are in the HACS integration are missing from the core one.

What version of Home Assistant Core has the issue?

core-2024.11.b1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

LG thinq

Link to integration documentation on our website

None available

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 6 days ago

Hey there @lg-thinq-integration, mind taking a look at this issue as it has been labeled with an integration (lg_thinq) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `lg_thinq` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign lg_thinq` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


lg_thinq documentation lg_thinq source (message by IssueLinks)

joostlek commented 6 days ago

Please keep in mind that this integration is brand new and not related to the HACS one. Please elaborate more. Be aware that theoretically this is a feature request, so if its unable to be implemented this issue will be closed.

bschatzow commented 6 days ago

The integration that I have been using from HACS from https://github.com/ollo69/ha-smartthinq-sensors gives me 28 sensors where the new one that is now in core gives me 9.

image

image

Not sure how the HACS version has this many more, but many of them are useful.

joostlek commented 6 days ago

That's not the full list of entities, you have more like events

bschatzow commented 6 days ago

Your are correct. I only listed the created sensors. The new integration also has two events.
image

joostlek commented 6 days ago

Can you also check the state of these entities in the dev tools? It will show you all the event types possible

bschatzow commented 6 days ago

Screenshot_20241101-081728 Don't see tub clean here

joostlek commented 6 days ago

Can you also post the notifications one for completeness? In that case it looks like your device does not post the tub clean notification. But that is probably an issue on LGs side

bschatzow commented 6 days ago

Screenshot_20241101-083010

bschatzow commented 6 days ago

What is strange as this information is in their app and somehow it is gotten with the hacs version. Thanks for all your help. It is nice that a major manufacturer is supporting HA. I only hope they will continue and make it better. Unlike the genie integration that worked for one month after they took over.

bschatzow commented 6 days ago

Screenshot_20241101-084231 App info

luca-angemi commented 5 days ago

I posted this on another issue, but same concept.

Also I know it's probably not the right place to talk about this but since the integration it's new, I'll try! I have a washing machine and so far I used a custom integration which also provides a select for the course selection. https://github.com/ollo69/ha-smartthinq-sensors/blob/abc27f2999604449e1173578ed11a6f55b60a8f5/custom_components/smartthinq_sensors/select.py#L44 Is it difficult to add that to the core integration?

dougiteixeira commented 4 days ago

I have an air conditioner that, with the custom integration, exposes switches to control the display light and jet mode.

image

Same for power and filter life sensors. image

I tried to include this in the official integration but I couldn't. LG's documentation doesn't list these controls in the air conditioning device profile, so it probably won't be possible to include them. 😢

The device status response from the API used by the official integration:

    "response": {
        "airConJobMode": {
            "currentJobMode": "COOL"
        },
        "powerSave": {
            "powerSaveEnabled": false
        },
        "temperature": {
            "currentTemperature": 26.5,
            "targetTemperature": 18,
            "unit": "C"
        },
        "airFlow": {
            "windStrength": "HIGH"
        },
        "operation": {
            "airConOperationMode": "POWER_ON"
        },
        "timer": {
            "relativeStartTimer": "UNSET",
            "relativeStopTimer": "UNSET"
        },
        "sleepTimer": {
            "relativeStopTimer": "UNSET"
        }
    }
MichaelStruck commented 4 days ago

Joining the conversation to track this as I also use the tub wash count via the HACS integration and saw ThinQ will be supported in HA 2024.11. The HACS integration is a high bar, but hoping native integration can match at least the feature I rely on.

aejohnson311 commented 13 hours ago

Total newb here but just installed the integration and was hoping to see the energy usage available to me in the ThinQ mobile app. Is that at all possible in future versions?

ExquisiteMetropolis commented 7 hours ago

Adding to this topic:

Thanks for taking the time/effort to add LG to Home Assistant, however it's far from functional & complete. I've been using a HACS version for the same already for a year now. For now I will stick to that. Ref: https://github.com/ollo69/ha-smartthinq-sensors

Why not team up with the author of the HACS version? As you can see from the screenshots below, I can't even turn on my airco unit with the LG version. Where as the HACS version presents me with several options. Also the HACS version has more entities than the LG variant.

For now, I will stick with the HACS version.

LG: image

HACS: image

LG: image

HACS: image

qemical commented 7 hours ago

HACS version from @ollo69 is absolutely better. I have an Air to Water Heat Pump and the official integration shows me a simple switch for the water heater

image

There is no desirable temperature nor current water temperature. Comparing with the custom one shows this:

image

Custom integration I believe it uses the app auth. However, API I guess is not providing that information yet.

ianfretwell commented 5 hours ago

Switched over to the 'official' integration, like many posts above, for my dryer...only to find that it too is missing many sensors that appeared with the HACS integration. The new integration is showing just 6 entities whereas I'd have been expecting something like 20!

This includes many that the documentation seems to suggest SHOULD exist such as 'Remaining Time' - but it's nowhere to be found as yet. Tried reloading the integration whilst the dryer is on (& running too) but this makes no difference whatsoever.

joostlek commented 5 hours ago

FYI, there used to be timers, but we removed them during the beta as they did not meet our expectations of user experience. We chose to remove them to add them back in a better way, than to have a massive breaking change in the future.

ianfretwell commented 5 hours ago

OK - makes sense - thanks. Maybe the main documentation page should mention that somewhere - as currently it's perhaps a little misleading about what will be provided.

joostlek commented 5 hours ago

Oh good point, I forgot to update the docs

16-9 commented 9 minutes ago

In my case, I have "No devices or entities" listed under my integration. Since the HACS module works for me, it confirms that my appliances are properly registered with ThinQ. Will be very happy to help debug.