search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.29k stars 30.61k forks source link

Cast: Add "URL" to description and names of "View path" and "Dashboard path" for consistency #129618

Open NoRi2909 opened 23 hours ago

NoRi2909 commented 23 hours ago

The problem

In the description of "View path" the word "URL" is missing:

https://github.com/home-assistant/core/blob/5900413c08e27a4402a0a24f64185d0269a8e8d2/homeassistant/components/cast/strings.json#L50-L56

Should be

 "description": "The URL path of the dashboard view to show."

as that field is just labelled "URL" in the dashboard editor UI:

image

For even more consistency with the above UI you might want to use URL instead of path for

  "name": "Dashboard URL", 

  "name": "View URL",

That this is just a path part of a URL is then explained in the two descriptions.

Note: I stumbled over this a bit harder as the German translators had turned "view path" into "viewing a path" which made things even worse. I fixed that in Lokalise yesterday.

What version of Home Assistant Core has the issue?

2024.11.0b1

What was the last working version of Home Assistant Core?

n/a

What type of installation are you running?

Home Assistant OS

Integration causing the issue

https://rc.home-assistant.io/integrations/cast

home-assistant[bot] commented 23 hours ago

Hey there @emontnemery, mind taking a look at this issue as it has been labeled with an integration (cast) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `cast` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign cast` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)

cast documentation cast source (message by IssueLinks)