home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.29k stars 30.61k forks source link

Keenetic Integration #129624

Open cataseven opened 21 hours ago

cataseven commented 21 hours ago

The problem

The problem is as Keenetic routers remain in cache mode for a while for the devices disconnected, Keentic integration is not working properly as device tracker for the devices go from home to not_home. I think the reason is that integration is requesting the active device list from the router. But it should simply just ping the device and find out if it is connected or not. Like the integration Ping (ICMP). This integration works great beacuse it is directly pingin the device over its ip

What version of Home Assistant Core has the issue?

2024.10.4

What was the last working version of Home Assistant Core?

2024.10.4

What type of installation are you running?

Home Assistant OS

Integration causing the issue

keenetic_ndms2

Link to integration documentation on our website

https://github.com/home-assistant/core/tree/dev/homeassistant/components/keenetic_ndms2

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 21 hours ago

Hey there @jpbede, mind taking a look at this issue as it has been labeled with an integration (ping) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `ping` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign ping` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


ping documentation ping source (message by IssueLinks)

home-assistant[bot] commented 21 hours ago

Hey there @foxel, mind taking a look at this issue as it has been labeled with an integration (keenetic_ndms2) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `keenetic_ndms2` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign keenetic_ndms2` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


keenetic_ndms2 documentation keenetic_ndms2 source (message by IssueLinks)

foxel commented 19 hours ago

@cataseven the integration is intended to ask the router whether the device is online. If the router thinks it's online, the integration states it's online.

If you want ping checks use ping integration. BTW not all devices we can track with router integration answer ping and/or are located on the same network the HA can reach

cataseven commented 18 hours ago

Thanks but What I want is not the ping checks "purely". I want to use only 1 integration for a simple device tracking feature.

for users device tracking means mobile phone, tablets etc. All these devices respond ping checks so we can handle both device tracking and other features under 1 integration after a simple development.

Kewnetic Integration can do both ping and online status checks in order. Or also user can define any entitiy as device tracker and integration only ping that device, other devices remain on online check procudure.

Keenetic integration is so close to handle this but needs minor update. Why would we need 2 integration as we are that close to fix it under one?

Edit: Also currently under this conditions, we see that the integration cannot be used as device tracker, and we should understand that considering "online status" method is not the correct method for device tracking