search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.98k stars 31.02k forks source link

Can't remove once added LAN devices #130394

Open boennhoff opened 2 weeks ago

boennhoff commented 2 weeks ago

The problem

I am trying hard to add my fritzbox using the "AVM FRITZ!Box Tools" integration without adding any LAN devices (yet). The option "Enable new added entities" always seems to be activated by default, and I can't find a way to only activate it after having added the box itself. I always have all my LAN devices added initially, without any means to remove them again.

I even tried adding the box, then disabling the permission of the special user within the fritzbox late enough for the box to be recognized but failing to initialize, so that I can disable the "Enable new added entities". But after setting permissions back, and reloading the integration it adds again all existing LAN devices.

I was even thinking about removing all devices from the fritzbox just to achieve my goal of using this integration without getting my system flooded with devices I'll probably never use... but this is just too much effort for this tiny misbehavior.

I could try providing a PR if someone would push me into the right direction. I imagine it to be just a few lines of code if you know where to put them:

  1. Adding a checkbox saying "Directly add existing LAN devices" to the user/password init dialog
  2. During initialization: if (checkbox) { add LAN devices } else { disable "Enable new added entities" }

What's your thoughts?

What version of Home Assistant Core has the issue?

core-2024.11.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

AVM FRITZ!Box Tools

Link to integration documentation on our website

https://www.home-assistant.io/integrations/fritz

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 2 weeks ago

Hey there @aarondavidschneider, @chemelli74, @mib1185, mind taking a look at this issue as it has been labeled with an integration (fritz) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `fritz` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign fritz` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)

fritz documentation fritz source (message by IssueLinks)