home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
74.21k stars 31.16k forks source link

'Change device type of a switch' dialog should behave consistently with corresponding entity dialog #130497

Open NoRi2909 opened 3 weeks ago

NoRi2909 commented 3 weeks ago

The problem

When you create a Helper of type 'Change device type of a switch' you get the following dialog:

Screenshot 2024-10-19 23 32 50

For Invert state it says: "… only supported for cover, lock and valve."

But the New Type popup right below also offers fan, light and siren in addition. This is misleading as the order of the UI elements contradicts this. They should influence each other top to bottom and left to right.

The Invert state toggle should be placed below the New Type popup. This should then disable or hide the toggle if an unsupported type is selected, and switch the explanation.

The entity dialog already does this perfectly and its behavior just needs to be copied over to the creation dialog:

image

image

image

To reproduce create a 'Change device type of a switch' , then open its settings dialog. There everything behaves correctly.

What version of Home Assistant Core has the issue?

core-2024.11.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Change device type of a switch

Link to integration documentation on our website

https://www.home-assistant.io/integrations/switch_as_x

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 3 weeks ago

Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (switch_as_x) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `switch_as_x` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign switch_as_x` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


switch_as_x documentation switch_as_x source (message by IssueLinks)