home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.71k stars 30.84k forks source link

Nexia: Wrong description keys for all services #130772

Open NoRi2909 opened 3 hours ago

NoRi2909 commented 3 hours ago

The problem

The description keys for all three services / actions of the Nexia integration are wrong.

They show up when calling up the action and should explain the purpose of each action. Instead they try to explain some data field they supply, which is actually found in the "description" keys below them in the "fields" section.

https://github.com/home-assistant/core/blob/9711816542b581d7c40a3d69668c3711d5af7c23/homeassistant/components/nexia/strings.json#L64-L67

Sets the air cleaner mode of the thermostat.

https://github.com/home-assistant/core/blob/9711816542b581d7c40a3d69668c3711d5af7c23/homeassistant/components/nexia/strings.json#L75-L77

Sets the target humidity of the thermostat.

https://github.com/home-assistant/core/blob/9711816542b581d7c40a3d69668c3711d5af7c23/homeassistant/components/nexia/strings.json#L85-L87

Sets the HVAC operation mode of the thermostat.

I stumbled over these strings several times trying to translate them into German. We will probably never encounter these devices over here, but we still need to provide all translations for consistency. ;-)

What version of Home Assistant Core has the issue?

core-2024.11.2

Integration causing the issue

Nexia/American Standard/Trane

Link to integration documentation on our website

https://www.home-assistant.io/integrations/nexia/

home-assistant[bot] commented 3 hours ago

Hey there @bdraco, mind taking a look at this issue as it has been labeled with an integration (nexia) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `nexia` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign nexia` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


nexia documentation nexia source (message by IssueLinks)