home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.75k stars 30.86k forks source link

Google Calendar: Missing strings for translations in Options dialog #130794

Open NoRi2909 opened 14 hours ago

NoRi2909 commented 14 hours ago

The problem

The Options dialog for Google Calendar is missing the strings for

Read/Write access (can create events)

Read-only access

so they don't show up translated in the dialog:

Screenshot 2024-11-17 09 41 24

Looks like they should be added here:

https://github.com/home-assistant/core/blob/445690588c855498b56561805ed652a12f36a21d/homeassistant/components/google/strings.json#L38-L46

What version of Home Assistant Core has the issue?

core-2024.11.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Google Calendar

Link to integration documentation on our website

https://www.home-assistant.io/integrations/google

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 14 hours ago

Hey there @allenporter, mind taking a look at this issue as it has been labeled with an integration (google) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `google` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign google` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


google documentation google source (message by IssueLinks)

joostlek commented 13 hours ago

The solution would probably be to change to a selector. An example for a select selector getting translations can be found in https://github.com/home-assistant/core/pull/130443