home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
74k stars 31.05k forks source link

Adding Roborock Integration fails with unknown error #131169

Open Svn74 opened 6 days ago

Svn74 commented 6 days ago

The problem

Trying to add my S8 Max V Ultra with the Roborock Integration. After inserting my email and entering the code I got from roborock I get an unknown exception.

What version of Home Assistant Core has the issue?

core-2024.11.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Roborock

Link to integration documentation on our website

https://www.home-assistant.io/integrations/roborock

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Logger: homeassistant.components.roborock.config_flow
Quelle: components/roborock/config_flow.py:109
Integration: Roborock (Dokumentation, Probleme)
Erstmals aufgetreten: 14:08:38 (2 Vorkommnisse)
Zuletzt protokolliert: 14:21:47

Unexpected exception
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/roborock/config_flow.py", line 109, in async_step_code
    login_data = await self._client.code_login(code)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/roborock/web_api.py", line 172, in code_login
    raise RoborockInvalidUserAgreement(
roborock.exceptions.RoborockInvalidUserAgreement: User agreement must be accepted again - or you are attempting to use the Mi Home app account.

Additional information

No response

home-assistant[bot] commented 6 days ago

Hey there @lash-l, mind taking a look at this issue as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `roborock` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign roborock` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


roborock documentation roborock source (message by IssueLinks)

Elyahou commented 5 days ago

I have the same issue when reauthenticating

Svn74 commented 5 days ago

After I was asked to accept the conditions in the Roborock App and I did I now was able to integrate it. No clue why I was asked to confirm at a random time after I installed everything already yesterday?!

For me this is solved.

hacscred commented 5 days ago

After I was asked to accept the conditions in the Roborock App and I did I now was able to integrate it. No clue why I was asked to confirm at a random time after I installed everything already yesterday?!

For me this is solved.

You could be useful and contact Roborock support such that the next person doesn't need to see that.

I wouldn't buy a robot that asks me multiple times to agree to changed conditions. I am sure many would agree, because the whole point of a robot is to save time.

Svn74 commented 5 days ago

You could be useful and contact Roborock support such that the next person doesn't need to see that.

done!

szavoda commented 5 days ago

For me, I had to revoke my current user agreement in the app (Profile -> About Us -> User Agreement), log in again, accept new agreement, and finally, restart HA.