home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
74.18k stars 31.15k forks source link

Improve name and description of Include list, fix `holidays` keyword name #132188

Open NoRi2909 opened 15 hours ago

NoRi2909 commented 15 hours ago

Proposed change

The Workday integration allows the setup of different workday rules for different members of a household, e.g. So "is a workday" is the result of the 'Workday: Check date' action with the respective config used as its target.

If one person only works on Wednesday to Saturday you can set those in the first list provided as the basis to calculate on. And another person might have a completely different list of possible days to include.

Therefore it is irritating that the first field in the configuration is already named "Workdays":

Screenshot 2024-12-03 17 41 47

What should the user enter here when this is the result expected at the end of the process?

Therefore this should be renamed "Includes" matching the "Excludes" list right below it. The explanation of both fields should also avoid the use of the word "workday" or "working days" at this point.

By using "List of weekdays to include / exclude, plus the keyword holidays" it becomes much clearer what to select here. The explanation of how the use holidays should be included in both as it's available both for Includes and Excludes.

In addition the current explanation used holiday which does not match what is presented on screen.

Type of change

Additional information

Checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

To help with the load of incoming pull requests:

home-assistant[bot] commented 15 hours ago

Hey there @fabaff, @gjohansson-st, mind taking a look at this pull request as it has been labeled with an integration (workday) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `workday` can trigger bot actions by commenting: - `@home-assistant close` Closes the pull request. - `@home-assistant rename Awesome new title` Renames the pull request. - `@home-assistant reopen` Reopen the pull request. - `@home-assistant unassign workday` Removes the current integration label and assignees on the pull request, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
home-assistant[bot] commented 11 hours ago

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.