Open NoRi2909 opened 15 hours ago
Hey there @fabaff, @gjohansson-st, mind taking a look at this pull request as it has been labeled with an integration (workday
) you are listed as a code owner for? Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
Proposed change
The Workday integration allows the setup of different workday rules for different members of a household, e.g. So "is a workday" is the result of the 'Workday: Check date' action with the respective config used as its target.
If one person only works on Wednesday to Saturday you can set those in the first list provided as the basis to calculate on. And another person might have a completely different list of possible days to include.
Therefore it is irritating that the first field in the configuration is already named "Workdays":
What should the user enter here when this is the result expected at the end of the process?
Therefore this should be renamed "Includes" matching the "Excludes" list right below it. The explanation of both fields should also avoid the use of the word "workday" or "working days" at this point.
By using "List of weekdays to include / exclude, plus the keyword
holidays
" it becomes much clearer what to select here. The explanation of how the useholidays
should be included in both as it's available both for Includes and Excludes.In addition the current explanation used
holiday
which does not match what is presented on screen.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: