0.66.x xy_color broken

[NaffanDroo]

Home Assistant release with the issue:

0.66.1

Last working Home Assistant release (if known): 0.65.6

Operating environment (Hass.io/Docker/Windows/etc.):

hass.io Component/platform:

Lights

Description of problem: As in my comments on: https://github.com/home-assistant/home-assistant/pull/13465 @balloob Is this the change that made my colours go pink? My scene sets this for example:

  light.kitchen_lightstrip:
    state: on
    brightness: 107
    xy_color: [0.4575, 0.4099]

Scene gen detects the light has actually been set to:

  light.kitchen_lightstrip:
    state: on
    brightness: 107
    xy_color: [0.448, 0.419]

Just to confirm, I rolled back to 0.65.6 and set the same scene, then ran scenegen:

  light.kitchen_lightstrip:
    state: on
    brightness: 107
    xy_color: [0.4575, 0.4099]

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

name: Dimmer 01
entities:
  light.kitchen_lightstrip:
    state: on
    brightness: 107
    xy_color: [0.4575, 0.4099]

Traceback (if applicable):

Additional information: Guessing it was this pull somehow... https://github.com/home-assistant/home-assistant/pull/13465

[ghost]

Also color is broken on zwave device... When i try set white color my LEDs on RGBW Zwave Fibaro i can not set.

[Alcatr4zz]

I'm having a similar issue as @pepeEL . I can't change the color of my Z-Wave Zipato RGBW bulb since 0.66.x. Setting the brightness still works perfectly fine.

[NaffanDroo]

Just to note that this is still broken in the beta 0.67.0b0 - it may not be pink, and has gone green but ultimately the issue is the same - something in 0.66 broke XY colours for Hue and it hasn't been restored yet despite the efforts of the above merge.

I'd comment on the merge but it is locked by @amelchio.

[NaffanDroo]

Just a further cross comment to help anyone looking at this; Expected snippet from my scene:

  light.living_room:
    state: on
    brightness: 254
    xy_color: [0.4575, 0.4099]

Actual from scene gen:

  light.living_room:
    state: on
    brightness: 254
    xy_color: [0.43, 0.459]

[NaffanDroo]

(Apologies for the close and reopen - fat fingers!)

[amelchio]

Is it your bulbs or the web UI that has the wrong color?

[NaffanDroo]

Bulbs, web ui shows them as green too

[lukhas]

Hello, any chance of that fix landing in a 0.66 point release?

[amelchio]

No but it will be in 0.67 this weekend (or you can get the beta already today).

[NaffanDroo]

This beta is still broken: Expected from my scene:

  light.living_room:
    state: on
    brightness: 254
    xy_color: [0.4575, 0.4099]

Actual from scenegen:

  light.living_room:
    state: on
    brightness: 254
    xy_color: [0.445, 0.434]

[amelchio]

How is the color on the bulb now?

[Nutti85]

Colors are the same. Any fix included in b1 hasn't fixed anything.

[NaffanDroo]

It is in the orange part of the colour wheel... but clearly the numbers aren't the same as the scene.

[NaffanDroo]

@balloob should we reopen this issue? I don't seem to have permissions to do the honours.

[amelchio]

So it fixed the problem of being green 👍.

[balloob]

The numbers will never be the same as the scene. Lights will try to go to the requested value but cannot guarantee that they can exactly represent all requested colors.

[Nutti85]

Well, if you get a totally different color and not just a different hue it's broken IMO. I still get green in b1.

[NaffanDroo]

@balloob This issue was about it being broken from 0.66 - it still is, prior to that version you get what you ask for. I don’t think it’s reasonable to think it should be different now when it was fine before...

I do appreciate the efforts but it’s still busted and green if I select a yellow colour in the wheel.

Surely this should just be simple numbers... I set x, I used to get x, now I get g = wrong

What was introduced in 0.66 that changed it all?

[NaffanDroo]

Please can we reopen, this has never been fixed by any change so far and is now spanning both 0.66 and 0.67, probably affecting a lot of people if they upgraded.

It worked before those releases... now one of the most common uses of Home assistant has gone from get what you code, to a strangely determined value.

If reopening isn’t the process, I can raise a new issue and reference this one but that seems illogical given it was never resolved

[Nutti85]

Agree. Philips Hue is "marketed" as working out of the box with Hass, now it's not. If this isn't reopened we should keep reporting it as a bug until it's fixed.

[amelchio]

Home Assistant 0.66 included #11288 which is a huge cleanup that could well have introduced multiple subtle errors. We need to fix those one by one and we are in fact making progress. Putting everything into a single "it's broken" issue makes it hard to track that progress so please do open new issues.

@NaffanDroo We should ignore scenegen output until the physical bulb at least shows the correct color. You have previously talked about pink and green but you did not yet make it clear whether the bulb now shows the expected color for your scene, i.e. the color that you get with 0.65?

Suddenly changing the test case to use the color wheel is not helpful. It's a different code path and could have a different error. Most likely, though, I think you will find that a similar greenish color was set in 0.65?

@Nutti85 You just keep saying that it is broken. That is not an error report. Please file a separate issue where you describe exactly what you are doing and how it doesn't work. Also include model/generation of your bulbs. Thanks.

[balloob]

I'm going to hide all the comments that do not add anything to the discussion.

[balloob]

Actually going to lock this issue. People can report new issues, break it down per platform (hue, z-wave etc). Don't use external tools to validate things. Only bug reports based on info reported in the state machine will be accepted.