home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.81k stars 30.51k forks source link

KNX component configuration: fire_event_filter is not optional #14332

Closed derandiunddasbo closed 6 years ago

derandiunddasbo commented 6 years ago

Home Assistant release with the issue: 0.68.1

Last working Home Assistant release (if known): not known

Operating environment (Hass.io/Docker/Windows/etc.): Docker @ Synology

Component/platform: https://www.home-assistant.io/components/knx/

Description of problem: The KNX component documentation states, that the fire_event_filter configuration is optional. But adding only fire_event to the config, omitting fire_event_filter results in a config error:

Invalid config for [knx]: some but not all values in the same group of inclusion 'fire_ev' @ data['knx'][]. Got None. (See /config/configuration.yaml, line 96). Please check the docs at https://home-assistant.io/components/knx/

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

knx:
  tunneling:
    host: '192.168.4.42'
    port: 3671
    local_ip: '192.168.4.3'
  fire_event: True
#  fire_event_filter: ["*/*/*"]

Traceback (if applicable):

Additional information: It should either be made more clear in the documentation, that fire_event_filter is no longer optional, if fire_event is used, or fire_event_filter should become truly optional, i.e. default to ["*/*/*"] if omitted in the config.

OttoWinter commented 6 years ago

From the documentation:

If fire_event is set fire_event_filter has to be specified. fire_event_filter defines a list of patterns for filtering KNX addresses. Only telegrams which match this pattern are sent to the HOme [sic!] Assistant event bus.

derandiunddasbo commented 6 years ago

Oops, thanks. I should actually read the documentation. Erm... ;-)