home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.14k stars 29.81k forks source link

Meraki device tracker does not return expected validator #15303

Closed ghost closed 3 years ago

ghost commented 6 years ago

Home Assistant release with the issue:

Home Assistant 0.72.1

Last working Home Assistant release (if known): Unknown

Operating environment (Hass.io/Docker/Windows/etc.): Hassio docker

Component/platform:

device_tracker/meraki.py

https://www.home-assistant.io/components/device_tracker.meraki/

Description of problem:

returns validator in incorrect format, possibly not json. when using browser it downloads file called meraki that contains the validator but meraki dashboard can not validate the url.

code should look something like this:

# Respond to Meraki with validator
@app.route('/', methods=['GET'])
def get_validator():
    print("validator sent to: ",request.environ['REMOTE_ADDR'])
    return validator

An example cmx receiver is here:

https://github.com/dexterlabora/cmxreceiver-python/blob/master/cmxreceiver.py

jacobwilsonnet commented 6 years ago

same issue

ghost commented 5 years ago

any update on fixing this?

ghost commented 5 years ago

Still broke

wlraider70 commented 5 years ago

Will The ssl profile fix this?

http:
  ssl_profile: intermediate
ghost commented 5 years ago

still broke, intermediate profile did not fix it.

JuniorGamingTime commented 5 years ago

Is this still an issue you are experiencing? Can you please try upgrading to the latest version of Home Assistant (0.90) and report back if this is still a problem? Thanks!

thomashpettersen commented 5 years ago

It's the same problem in 0.90.1

thomashpettersen commented 5 years ago

I've also tried again in 0.90.2, still the same.

thomashpettersen commented 5 years ago

Now I've upgraded to 0.91.0, and still same problem.

Returns validator in incorrect format. When using browser it downloads file called meraki that contains the validator, but Meraki dashboard can not validate the url.

ghost commented 5 years ago

Same

On Apr 5, 2019, at 5:20 AM, thomashpettersen notifications@github.com wrote:

Now I've upgraded to 0.91.0, and still same problem.

Returns validator in incorrect format. When using browser it downloads file called meraki that contains the validator, but Meraki dashboard can not validate the url.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

thomashpettersen commented 5 years ago

I've also tried again in 0.91.2, still the same.

ghost commented 5 years ago

Nobody has actually tried to fix it, so I don’t understand why they keep asking us to download the newest version because the python has not changed.

On Apr 9, 2019, at 8:34 AM, thomashpettersen notifications@github.com wrote:

I've also tried again in 0.91.2, still the same.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

thomashpettersen commented 5 years ago

I've also tried in 0.91.4, but i seems like the problem isn't in the version we use.

thomashpettersen commented 5 years ago

Today I've tried it with 0.92.1, but still no fix.

ghost commented 5 years ago

That is because nobody has actually tried to fix it ever and they continue to close this by telling everyone to update home assistant instead of actually addressing the issue.

On Apr 30, 2019, at 3:45 AM, thomashpettersen notifications@github.com wrote:

Today I've tried it with 0.92.1, but still no fix.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

thomashpettersen commented 5 years ago

Maybe it's because it seems like there is no codeowner for the Meraki integration. See link : https://github.com/home-assistant/home-assistant/blob/dev/CODEOWNERS#L262

thomashpettersen commented 5 years ago

Still the same in 0.93.1. Is it possible for someone to take a look at it? @MartinHjelmare @robbiet480

MartinHjelmare commented 5 years ago

I don't own the device so I can't test it.

thomashpettersen commented 5 years ago

I don't own the device so I can't test it.

There are no code-owners for the Meraki integration?

MartinHjelmare commented 5 years ago

It doesn't seem so.

jeffh0821 commented 5 years ago

The Meraki scanning API does not support sending tokens for authentication. Requires an open REST API endpoint which is secured through the exchange of a Validator and Secret. My only thought on resolving this is to somehow leverage a Webhook endpoint - but I'm not sure how to enable those outside of automation.

stale[bot] commented 4 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

ghost commented 4 years ago

This was never fixed, updating to the latest addition doesn’t fix the issue if you don’t update the relevant code.

On Sep 22, 2019, at 10:17 AM, stale[bot] notifications@github.com wrote:

 There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

DiabeticJedi commented 4 years ago

Well this is disappointing. My Meraki gear arrives on Friday so I just tried to get it set up now and I'm learning that this component doesn't work... I may have to leave my Asus router hooked up for awhile longer

ghost commented 4 years ago

Yup still doesn’t work!

On Oct 2, 2019, at 6:13 PM, DiabeticJedi notifications@github.com wrote:

 Well this is disappointing. My Meraki gear arrives on Friday so I just tried to get it set up now and I'm learning that this component doesn't work... I may have to leave my Asus router hooked up for awhile longer

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

filikun commented 4 years ago

They seemed to remove the api_password now also https://github.com/home-assistant/home-assistant/issues/15376

P1X3L8 commented 4 years ago

Does anyone know if this will ever be fixed, or has it been abandoned? Thank you.

stale[bot] commented 4 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

thomashpettersen commented 4 years ago

Still not working, 0.108.8

P1X3L8 commented 4 years ago

Still broken and slightly moldy

ghost commented 4 years ago

Very moldy

On Apr 23, 2020, at 12:23 PM, PiXEL8 notifications@github.com wrote:

 Still broken and slightly moldy

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

stale[bot] commented 4 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

ghost commented 4 years ago

This is not resolved

On Jul 25, 2020, at 12:30 AM, stale[bot] notifications@github.com wrote:

 There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

coreyjansen commented 3 years ago

My meraki integration randomly stopped working. is anyone able to get it working?

123dev commented 3 years ago

My meraki integration randomly stopped working. is anyone able to get it working?

Did it stop working recently for you? because it's be broken for a long time. See this for a possible workaround.

coreyjansen commented 3 years ago

I am guessing it might have been my db getting to large. seems to be working now. Thanks

123dev commented 3 years ago

Weird Unless you're running really old version of Home Assistant, the component as is shouldn't be working for you. Yeah and I hate it that in no time device_tracker.yaml file gets bloated with this component.

coreyjansen commented 3 years ago

Yes I know what you mean, my device_tracker.yaml is full of every wifi and Bluetooth device in my area. If you find anyway to have that stop writing let me know

123dev commented 3 years ago

Yes I know what you mean, my device_tracker.yaml is full of every wifi and Bluetooth device in my area. If you find anyway to have that stop writing let me know

This was bugging too much so I made some changes and added a config capture_all (default false) to not capture any device that doesn't actually connect to the Meraki (ie no more passer by MACs) You have to set it to true if you want the original behavior.

You can find my changes here: https://github.com/123dev/core/blob/dev/homeassistant/components/meraki/device_tracker.py

coreyjansen commented 3 years ago

Anyone else having the issue where their device tracker is not working and when I try to access the /api/meraki endpoint I am getting a 404 error? Only started happening as of one of the recent updates

github-actions[bot] commented 3 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

123dev commented 3 years ago

Not sure why this issue would magically work with using the latest HASS, the Meraki component hasn't been updated in ages.

github-actions[bot] commented 3 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.