home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
70.47k stars 29.4k forks source link

Opentherm gateway support set_clock and set_outside_temp #16670

Closed aequitas closed 5 years ago

aequitas commented 5 years ago

@mvn23 thanks for your work on otgw support in HA. I've been using MQTT with otmonitor before but will definitely start using this component now.

I've seen you already have support for set_clock and set_outside_temp in your python module. Are you already working on integration for both in the component? Otherwise I'll start working on them.

mvn23 commented 5 years ago

Those features in pyotgw have not been thoroughly tested yet, but they should be functional. Now that the opentherm_gw platform is integrated in Home Assistant I plan to improve the pyotgw module before adding new features to the platform. Feel free to start working on adding those features and if you encounter any issues with pyotgw, please let me know or file a PR.

frankhommers commented 5 years ago

I would like to have the flame_on exposed as well!

mvn23 commented 5 years ago

As of Home Assistant v0.79, flame_on is sort of exposed through STATE_HEAT. This state is now a result of ch_active and flame_on, rather than just ch_active. I am looking into a way to expose more info to Home Assistant, but it may take some time before it hits the Home Assistant repos. I have already done some work on set_outside_temp (exposed as a service so it can be called e.g. from an automation linked to another sensor/weather platform) and I plan to integrate more commands but the same applies here, it may take some time to hit the Home Assistant repos.

frankhommers commented 5 years ago

Great, that would be very useful. I use flame on to start my heaters pump ;-)

mvn23 commented 5 years ago

Support for binary sensors (flame_on etc) will be added in the next PR. Services (set_clock etc) will require a bug fix in the library, expect those after the binary sensors have been added.

andriej commented 5 years ago

One thing, maybe you've seen in protocol - is it possible to somehow 'override' room temperature over the thermostat value? It's placed totally wrong in my house and I'd like to report different temperature. I guess it won't, as it's own thermostat sensor, but worth trying at least. :-)

Also I'll be reporting outside temp from external sensor, as I don't have any physical one connected to boiler.

mvn23 commented 5 years ago

I don't think it will be possible to override the room temperature. All calculations are normally done by the thermostat, which then tells the boiler to adjust it's output.

The outside_temp sensor will report the value it finds in the protocol. If that value comes from an actual sensor (i.e. connected to the thermostat, boiler or gateway GPIO) it will report the measured value. After services are added later on it will be possible to provide an outside temperature from another source, which will then be reported by the sensor. For this to have any effect, your thermostat will need to support OTC (Outside Temperature Correction).

andriej commented 5 years ago

Ok, so I'll have to wait with using the component then. Currently I'm reporting the value to py-mqtt-otgw. The best would be outside_sensor: /entity/ - if provided, then overriden. :-)

mvn23 commented 5 years ago

17762 implements set_clock and set_outside_temp as services. Other requests have been added in #17625 and #17314. I think we can close this issue now.

aequitas commented 5 years ago

@mvn23 sure thing, sorry I neglected to pick these tasks up as I promised, but glad they are implemented now. Hope to find some time soon to get this working in HA.