search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.63k stars 30.4k forks source link

New owntracks, new problem #18964

Closed point-4ward closed 5 years ago

point-4ward commented 5 years ago

Home Assistant release with the issue: 0.83.0b2

Last working Home Assistant release (if known): This is a new thing isn't it??

Operating environment (Hass.io/Docker/Windows/etc.): Docker

Component/platform: Owntracks

Description of problem:

Edit - See below

point-4ward commented 5 years ago

Right - ok - I now have the integration in the list, but how do I gte the URL with the webhook and authorization key up when I need it?

If I go in to the 'configured' integration it just says 'no devices' - and clicking configure in the list says that I only need one instance? Can I really only get this URL and access token once??

What on earth was wrong with the old system that worked absolutely perfectly and didn't need all of this messing about?? Device tracking is a really important part of home automation, and making all these changes that only seem to serve to make things harder to implement is ridiculous. Surely these changes are supposed to make things easier?

point-4ward commented 5 years ago

On a side note, you can now close #18673 because you now don't need the username and device_id on the end of the url anymore.

Although apparently when the other people in my household get home and I have to change the configuration on their iphones (for the third time in a fortnight) it probably won't work because of #18927

This is really bad guys 👎

arsaboo commented 5 years ago

The idea is to (eventually) get rid of manually editing text files. You can use the one URL that is generated on multiple devices and the devices don't show in the integrations. You will see new device tracker entities.

point-4ward commented 5 years ago

Which would be fine if we were talking about long complicated configuration, but less than a fortnight ago this was a single line of text in the configuration file, and a url that you already knew.

Now it's a new complicated url, plus another complicated key, and you say I can use it 'on multiple devices' but I can't actually bring this information back up anywhere.

Not to mention that the whole point of the new authorisation system is supposed to be so that I can have a different authorisation token per device, so I can revoke access to one device if needed without affecting the others, which I can't do with this integration.

And then there's the fact that it doesn't work properly anyway, ios users can't get a response.

I'm all for making things 'easier' and 'more secure' , but this change hasn't achieved either of those goals and has just basically broken a fundamental part of many people's systems for zero advantage.

RS1979 commented 5 years ago

Mf-social, I feel your frustration. But this is the way this project works.

In the last few updates this project broke (only components I use): device tracking, many sensors, Z-wave integration, Google home configuration, climate control of Z-wave thermostats, Nello door opener, Nuki lock, mobile display and functionality of lovelace UI, authentication on most browsers. In addition, the device registry is buggy and in most instances not releasing entities that are deleted (Z-wave, for example, but I had the same problem with Hue and Tradfri bulbs). It basically never worked as advertised (for me), but just broke all kind of things.

I'm now several versions behind the official release schedule and only upgrade when I know I have a few free days to "repair" or roll back. Have a look at the new ASUSwrt component: The old way was working totally fine for all users, but without need they changed the device tracker and sensor to a component that is not working at all. Neither tracking nor sensors work, but nevertheless it was merged and is now in the release channel. I suspect it is the same with the Owntracks component.

I don't understand at all how such decisions are made in this project, and am considering to switch to a more rational project in the near future. I can only recommend you also try to find a more sane approach to such a central topic as home automation. In this project, "your change broke the function" is not a reason for anything. And before somebody brings up that it is done by volunteers: many projects are, but most of them don't break functionality without need or discussion or preparation or real-world testing.

Knoxie commented 5 years ago

The URL should at least show up when clicking on the integration. I can understand not yet having all the features there but setting up multiple devices without being able to reference the URL seems pretty silly/ridiculous.

In the future it would be great to see the URL inside the integration tab along with each device where you can rename it/give it custom photo/etc. But for now at minimum it should store the current URL.

arsaboo commented 5 years ago

@knoxie you can delete the existing integration and set it up again and you will get the URL. The URL is not displayed for security reasons.

arsaboo commented 5 years ago

@mf-social as I replied earlier, the integration works fine (the breaking change was an accident). Please note that you can delete the integration, which will revoke all the current devices and you can set it up again. So, the current integration delivers on all the promises.

point-4ward commented 5 years ago

@arsaboo - if it 'worked fine' there wouldn't be 4 separate issues open about it.

Also I don't think that if I want to add my girlfriend's device today, I first have to revoke my access can ever be considered as 'working fine'.

Saying 'the url is not displayed for security reasons' is clearly rubbish, anybody who can get to that page can already do much much worse to your system than tell it to track their phone.

The only promise delivered by this integration is the promise of breaking presence detection, and it's a sad state of affairs when that is overlooked and described as 'working fine'.

By all means close the issue if you're happy with how this is working, don't let the multiple people in the 4 issues on GitHub and the several threads on the forums for whom this is not working affect your operation any further.

balloob commented 5 years ago

You want a page to show all webhooks in the UI that are active? Sounds like a feature request. This is for issues.

Knoxie commented 5 years ago

I have mine working but it did take me a few tries.

I did the following things:

Luckily for me the _pixel was already what I had my device name as in my Known_devices.yaml so everything updated flawlessly. On the phone that didn't match the name i just manually edited the file to fix it.

On Fri, Dec 7, 2018 at 1:55 AM Marc Forth notifications@github.com wrote:

@arsaboo https://github.com/arsaboo - if it 'worked fine' there wouldn't be 4 separate issues open about it.

Also I don't think that if I want to add my girlfriend's device today, I first have to revoke my access can ever be considered as 'working fine'.

The only promise delivered by this integration is the promise of breaking presence detection, and it's a sad state of affairs when that is overlooked and described as 'working fine'.

By all means close the issue if you're happy with how this is working, don't let the multiple people in the 4 issues on GitHub and the several threads on the forums for whom this is not working affect your operation any further.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/home-assistant/home-assistant/issues/18964#issuecomment-445141007, or mute the thread https://github.com/notifications/unsubscribe-auth/ABAifIsoHLR6xsoJJ27kun56sN4sy0Q8ks5u2hD1gaJpZM4Y-lYG .

--

Knoxie commented 5 years ago

Knoxie you can delete the existing integration and set it up again and you will get the URL. The URL is not displayed for security reasons.

Make it so you have to type your password in again for HASS to show it then. What i'm saying is it seems silly to have to redo all the device trackers just so you can add one more. Or go to the device and open up the settings in app (Which doesn't hide the URL).

point-4ward commented 5 years ago

No, it wasn't a feature request, it was a bug report on a new feature that doesn't work.

Not to worry, so long as it all works for a couple of devs, screw the rest of us.

arsaboo commented 5 years ago

I don't know where you are getting that impression. The whole objective of the change was to make it easier for new users to start using Owntracks. I know I spent a ton of time when I just got started with HA to set up MQTT/Owntracks. The current integration allows any new user to configure the same with one click.

Your comment on configuring multiple devices is well take and, as Paulus indicated earlier, is a new feature that is currently being worked on (you are welcome to contribute). For the time being you can copy paste the URL from any of the existing device and use it on another device or delete the integration and set it up afresh.

Knoxie commented 5 years ago

For me the fact that it broke was annoying but, it honestly was very easy to setup. As a new user i would have had zero issues. The easier it is for newcomers the better.

point-4ward commented 5 years ago

@arsaboo - I get that impression because it doesn't work, and nobody gives a crap.

I subscribe to the beta versions of homeassistant so that I can help with these issues when they arise. This integration wasn't in the beta. In the beta you had to manually set the webhook. That worked fine on both ios and android, however the instructions on the webpage for android were incorrect.

I raised this as an issue, and got pretty much the same response as I got to this one "it works, you're wrong". As I said in that thread, if it was just me then that's fine, sorry for wasting everybody's time. Only it's not just me, it's lots of people, and it isn't being addressed.

Copying the configuration to an ios device results in a 400 error, I cannot track 75% of my household currently.

I'm going to suggest that it's not 'easier for new users' because even experienced users can't get it to work. A new user can't set it up 'with one click', it is a royal pain in the backside. They may, if they're lucky, be able to set it up with one click if they only intend to use owntracks on one android device.

Your anology to setting up owntracks with mqtt is a moot point, owntracks via http has only ever needed a single line of text in the configuration since its introduction.

As I said a few miles up this thread, this has actually made things more difficult, and it is NOT any more secure than the previous option. I have no problem with things being made easier and more secure, this does neither.

kirichkov commented 5 years ago

I'm not sure it's my place to comment on this, but I'll do it anyway.

Home Assistant is still at version 0.y.z. In general major versions starting with 0 are not considered "stable" or "for production use". I don't think anyone in charge of this project is claiming otherwise.

I do expect with every release, major or minor things to break at this stage. Once the project hits version 1.0.0, I'd not find things breaking for something "expected" or "normal". We all are "beta testers" at this stage. Fact is there's a multitude of automation projects out there. Some are free and some are commercial.

I've tried a bunch of open source projects, but none of them offered ME all of these integrations HASS offers me, so I stick with it and accept its drawbacks - like breaking changes, things occasionally not working, but I like the idea that I can simply create a fix because I have access to the source code. Whether this is acceptable, however, is something YOU have to decide for yourselves.

Last but not least I'd like to point you to this comment: "Every version of Home Assistant contains a breaking change, hence the higher version."

point-4ward commented 5 years ago

I don't have a problem with breaking changes, but I don't understand the point when they don't achieve anything. I do have a problem with things being broken for zero advantage and then when you report them to be broken getting told "it works, you're wrong".

There are close to a thousand live bug reports for this project, and prior to this change owntracks was working perfectly for everyone and was easy to implement. Yet the bugs go unaddressed and owntracks was changed. Not once was it changed, but 2 major changes in the space of a week. The first of those major changes still kept it working, just the documentation was not quite accurate. I don't really see that the change made anything any better, but at least it remained fairly easy to implement.

The second major change broke ios integration and made it really difficult to implement. This change has basically achieved nothing but messing people around, and broken something that was working fine.

Beta testers or not, there are a lot of us using this system to actually automate our homes and it's fine that functionality changes a bit here and there between versions, it's even fine when someone makes a mistake and accidentally breaks something major. What isn't fine is that when that happens, nobody cares.

balloob commented 5 years ago

Not once was it changed, but 2 major changes in the space of a week.

We did two major changes so we never had to do a breaking change again, so you didn't have to go around and update your families phones twice. We shipped both changes in a single release.

rookster1984 commented 5 years ago

I am having the same issue, I have no place in the configuration about owntracks, I go into it in the integrations tab and see no devices found (I don't know the url I need for clients), I try click the trash button at the top to try and delete it to try again, nothing happens. Can someone please tell me how to remove it so I can redo it please.