search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
74.09k stars 31.1k forks source link

Discovery Component/Zeroconf: Homekit seems to be enabled by default and can't be disabled starting in 0.94.x #24648

Closed heymoe closed 5 years ago

heymoe commented 5 years ago

Home Assistant release with the issue: 0.94.4 but the issue seems to have started in 0.94.x in general

Last working Home Assistant release (if known): 0.93.3

Operating environment (Hass.io/Docker/Windows/etc.): Docker (ArchLinux VM)

Component/platform: https://www.home-assistant.io/components/discovery/

Description of problem: It seems that with the changes to the Discovery component starting in 0.94.x, Homekit is now enabled by default where as in previous versions you had to enable it using:

discovery:
  enable:
    - homekit

Based on the component documentation, "homekit" is only an option for enable section and not for the ignore section. As such, there doesn't seem to be a way to disable Homekit now in 0.94.x and I'm getting new device discovery notifications for Homekit compatible devices (HomeKit Accessory: Ecobee in my case) on my network which I can dismiss but the notification comes back after awhile or after a reboot which is really annoying. I don't use Homekit so I don't want to see notification for it.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

discovery:
  ignore:
    - homekit

The above does not work to disable homekit

Traceback (if applicable):

N/A

Additional information: Another person has reported the same problem in the forums:

https://community.home-assistant.io/t/new-devices-discovered-disable-notification/122506

Kane610 commented 5 years ago

That option is deprecated. Homekit is discovered by zeroconf integration now. Check breaking changes from 0.94

heymoe commented 5 years ago

I looked at the breaking changes section in the 0.94.x release notes and don't see anything in there related to Homekit or Zeroconf.

All the info related to Homekit in the release notes point to this doc:

Which itself shows how to enable Homekit which makes it sound like it should be disabled by default.

There seems to be a discussion related to this in the pull request here:

But didn't seem like a decision was made. That discussion even notes that Homekit was opt-in before.

Moving Homekit to Zeroconf is fine but I don't see any information in the Zeroconf docs on how to disable discovery for Homekit devices other then opting-in by editing a manifest.json which I have no idea where that is to see if I can remove Homekit from it. I could disable zeroconf completely but then that means I can't discovery any of the other hardware the it can discover.

Eitherway, before 0.94.x, Homekit was not on by default and now it is and there doesn't seem to be an easy way to disable it or at least dismiss the new device discovered notification for found devices forever.

dasb00ter commented 5 years ago

I'm seeing similar. I don't own a single Apple product. How can I turn this off. I have manually configured my nanoleaf lights ages ago.

Here is the notification: HomeKitt Accessory: Nanoleaf Light Panels redacted HomeKit Accessory: Nanoleaf Light Panels redacted HomeKit Accessory: Nanoleaf Light Panels redacted HomeKit Accessory: Nanoleaf Light Panels redacted

heymoe commented 5 years ago

If this is now a Zeroconf component issue, can someone tag / label this as: integration: zeroconf or whatever so it will be seen by the correct group.

dasb00ter commented 5 years ago

@heymoe I dont know if I did this right and I suppose its duplicate but hope this helps

https://github.com/home-assistant/home-assistant/issues/24863

Jc2k commented 5 years ago

There are 2 seperate issues here:

Please don't open more tickets, this just means we spend more time triaging them and marking them as dupes instead of getting real work done.

ghost commented 5 years ago

Hey there @robbiet480, @Kane610, mind taking a look at this issue as its been labeled with a integration (zeroconf) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

Kane610 commented 5 years ago

This should be solved by enabling user to disable discoveries from the frontend. It's a solution that would work with ssdp and zeroconf alike so not only a zeroconf issue

Jc2k commented 5 years ago

Then I think this ticket should be closed - we have https://github.com/home-assistant/architecture/issues/250 to track a UI fix for persistent discovery notifications.

hellcry37 commented 5 years ago

this is very annoying please fix it asap, thank you