home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.13k stars 29.8k forks source link

Tahoma: Windows and Awnings open/close status reversed #25240

Closed dennismeng closed 4 years ago

dennismeng commented 5 years ago

Home Assistant release with the issue:

96.0

Last working Home Assistant release (if known): Believe it was 94.x

Operating environment (Hass.io/Docker/Windows/etc.):

Hass.IO Component/platform:

https://www.home-assistant.io/components/tahoma/

Description of problem: When opening rooflight windows and awnings, the state shows as "closed" and vise versa.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

tahoma:

Traceback (if applicable):

It was mentioned in this #24879

Additional information:

ghost commented 5 years ago

Hey there @philklei, mind taking a look at this issue as its been labeled with a integration (tahoma) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

Godtoh commented 5 years ago

Same issue here since 0.94....

dickesW commented 5 years ago

Same here: these are the states shown by Home Assistant for every device_class I own:

Entity State Attributes
cover.shutter open current_position: 0
device_class: shutter
cover.window open current_position: 0
device_class: window
cover.awning open current_position: 100
device_class: awning

These are the real states (current_position is taken from the VELUX INTEGRA® Control Pad KLR 200):

Entity State Attributes
cover.shutter closed current_position: 100
device_class: shutter
cover.window closed current_position: 0
device_class: window
cover.awning open current_position: 100
device_class: awning
Godtoh commented 5 years ago

Not only the state, but the position is reversed too. Same issue...

DjMoren commented 5 years ago

Same problem here. I have 2 awnings. If I check their state inspecting the requests made using directly the application in https://www.tahomalink.com, both are closed at 0 and opened at 100, but in HomeAssistant, one closes at 0 and the other one closes at 100.

For the person who is mantaining this plugin, this is a summary of the things I can see that may help:

io:VerticalExteriorAwningIOComponent

Phisical state core:ClosureState core:DeploymentState Position in HomeAssistant core:OpenClosedState State in tahomalink widget State in HomeAssistant
Fully open 100 - 0 closed open open
Fully closed 0 - 100 open closed closed

io:HorizontalAwningIOComponent

Phisical state core:ClosureState core:DeploymentState Position in HomeAssistant core:OpenClosedState State in tahomalink widget State in HomeAssistant
Fully open - 100 100 open open open
Fully closed - 0 0 closed closed closed

As we can see in the tables, the special thing to be handled is that the io:VerticalExteriorAwningIOComponent uses a reversed state in tahomalink, but the position to be sent is always the same, 0 to be fully closed and 100 to be fully open.

Disclaimer: I don't know if this is only in my case or it is general in this type of component (io:VerticalExteriorAwningIOComponent). If this is not allways the same, two settings like in zwave configuration would help solving the problem: invert_openclose_buttons and invert_percent.

wpetit commented 5 years ago

Same problem here with device_class: shutter for my rolling shutters.

medaemon commented 5 years ago

I have the issue with my covers and as I'm using map of my flat with images changing on status (open/closed covers) it makes me crazy each time I watch my map, I cannot help a lot sorry but please please reverse the change you made after 0.94 and you will be 🥇 for me :)

ktpx commented 5 years ago

I have two sunilus IO motors, and using this component they operate differently. One closes on open_cover, and the other closes on close, but position is wrong when its closed ( 0).

Godtoh commented 4 years ago

Checked some more, reverted the cover.py to https://github.com/home-assistant/home-assistant/pull/23024

State is good, position is still wrong. State now is open when the covers are open, however the position is 100 while it should be 0.

More to do than just the position.

psicot commented 4 years ago

Hello, same problem here with my roller shutters and my garage door.

Opened/closed states are reversed, while the arrows to open/close are well updated.

States are valid only when the roller shutters are opened between 1 and 99%.

psicot commented 4 years ago

I would add that via the homekit integration, the status is only reversed for the garage door, not for the roller shutters.