home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.87k stars 28.97k forks source link

AdGuard v2.3.0 switch.adguard_protection no longer working #30519

Closed dredzed closed 4 years ago

dredzed commented 4 years ago

Home Assistant release with the issue:

0.103.5 Last working Home Assistant release (if known):

Operating environment (Hass.io/Docker/Windows/etc.):

Hass.io Integration:

AdGuard https://www.home-assistant.io/integrations/adguard/ Description of problem: Since installing v2.3.0, the switch switch.adguard_protection no longer works. If I toggle it to off (developer tools/ states), it turns off for about 1 second, the toggles back on again. All other switches ( switch.adguard_parental_control etc ) behave normally. I can turn off AdGuard Protection from the ingress dashboard still. I love this add-on, but I do miss the ability to turn off the master switch from my Lovelace home page.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information: Developer tools log: "An error occurred while turning off AdGuard Home switch."

I can't see any error messages in adguard add-on log.

allanpersson commented 4 years ago

Maybe the issue should be opened here: https://github.com/hassio-addons/addon-adguard-home 🙏

dredzed commented 4 years ago

This is my first time raising an issue, and I was told to raise it here (from the forums), but I'm happy to move it if needed?

frenck commented 4 years ago

It is the correct place, the integration is not working. Will look at it as soon as possible

frenck commented 4 years ago

Issues were caused due to a breaking change in the API of AdGuard Home. I've opened up a PR to address the issue.

thundergreen commented 4 years ago

Some entites won't be avyilable. Seems like scan is too short or whatelse

image

After some time some entites apear and disappear (unavailable)

logs:

2020-03-24 09:28:50 WARNING (MainThread) [homeassistant.helpers.entity] Update of sensor.adguard_dns_queries is taking over 10 seconds
2020-03-24 09:28:50 WARNING (MainThread) [homeassistant.helpers.entity] Update of sensor.adguard_dns_queries_blocked is taking over 10 seconds
2020-03-24 09:28:50 WARNING (MainThread) [homeassistant.helpers.entity] Update of sensor.adguard_dns_queries_blocked_ratio is taking over 10 seconds

image

frenck commented 4 years ago

@thundergreen This issue has been closed and was fixed. Please raise a new issue instead of digging up old issues. Thanks 👍