home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.31k stars 30.62k forks source link

Meteoalarm doesn't update and misses translations #31447

Closed Mariusthvdb closed 4 years ago

Mariusthvdb commented 4 years ago

The problem

The binary_sensor created by the integration isn't updated according to the official website meteoalarm.eu. In my current case, I have an alert displayed for over 2 days now, while not active at all in the website..

Also, although having set the language to dutch, some of the main info is still showing in English (awareness_type, headline condition, urgency, severity, certainty,to name a few important ones)

Environment

Problem-relevant configuration.yaml

  - platform: meteoalarm
    name: Meteoalarm Brabant
    country: 'NL'
    language: 'ne'
    province: 'Noord-Brabant'

Traceback/Error logs

Additional information

Schermafbeelding 2020-02-03 om 10 28 39

earlier situation:

Schermafbeelding 2020-02-03 om 10 21 42

current situation:

Schermafbeelding 2020-02-03 om 21 19 39
probot-home-assistant[bot] commented 4 years ago

Hey there @rolfberkenbosch, mind taking a look at this issue as its been labeled with a integration (meteoalarm) you are listed as a codeowner for? Thanks!

Mariusthvdb commented 4 years ago

even when this is live:

Schermafbeelding 2020-02-06 om 16 37 49

HA binary_sensor.meteoalarm still is 'on'

Schermafbeelding 2020-02-06 om 16 39 27

condensed:

Schermafbeelding 2020-02-06 om 16 40 05
Mariusthvdb commented 4 years ago

yet another update, seeing this in the logs in ha 105.2:

2020-02-07 12:22:21 ERROR (MainThread) [homeassistant.components.binary_sensor] meteoalarm: Error on device update!
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 304, in _async_add_entity
    await entity.async_device_update(warning=False)
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 461, in async_device_update
    await self.hass.async_add_executor_job(self.update)
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/meteoalarm/binary_sensor.py", line 85, in update
    alert = self._api.get_alert()
  File "/usr/local/lib/python3.7/site-packages/meteoalertapi/meteoalertapi.py", line 34, in get_alert
    feed_data = xmltodict.parse(text)
  File "/usr/local/lib/python3.7/site-packages/xmltodict.py", line 327, in parse
    parser.Parse(xml_input, True)
xml.parsers.expat.ExpatError: no element found: line 20319, column 17
Mariusthvdb commented 4 years ago

ok, it gets worse...

have been in a alert state for the last couple of days, storm Ciara... None of this was reflected in the Meteo_alarm binary. I kept going on about the posted flooding above .

Now that is gone, and meteoalarm.eu showing this:

Schermafbeelding 2020-02-10 om 06 37 55

there is no alert whatsoever, and the binary_sensor.meteoalarm isn't created. Which means we can't even force update it.

Only after a restart of the instance a new binary_sensor was created.

Please have a look, because as this stands, the integration is really buggy, not to say pretty useless...

stale[bot] commented 4 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

rolfberkenbosch commented 3 years ago

MeteoAlarm have moved the website and api. The bigest problem was their api, it was very slow. I have created a new PR for this: https://github.com/home-assistant/core/pull/51383. Can you confirm in the next release if the problems are solved for you.