search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.21k stars 30.23k forks source link

Add Stop Effect to Lights more-info dialog #32446

Closed ghost closed 3 years ago

ghost commented 4 years ago

@SeanPM5 commented on Sep 4, 2019, 8:49 PM UTC:

Description of problem: You can turn on light effects from the more-info dialog for Lights, but there is no apparent way to turn these effects off. Seems that you have to turn the light off and then back on again, which is not obvious and can be a little confusing. Some examples of community posts referencing this: here, here, here.

It seems that sending effect: stop will stop the effect and restore your lights. I've tested this with Hue and it seems to work, but I am not 100% positive if this is a standard Home Assistant thing that all light platforms support?

I think that there should either be a "stop" option added inside of the dropdown when an effect is currently active like this (mockup 1):

stopeffectmock1

Or a stop button to the right of the "Effect" dropdown as pictured here (mockup 2):

stopeffectmock2

This issue was moved by iantrich from home-assistant/frontend#3619.

ghost commented 4 years ago

@balloob commented on Sep 4, 2019, 10:44 PM UTC:

If we would go for a button, only show it if we know an effect is active. I think I prefer making it part of the dropdown.

ghost commented 4 years ago

@SeanPM5 commented on Sep 5, 2019, 5:55 PM UTC:

There is one minor discoverability issue with the dropdown idea however.

If the "stop effect" choice is hidden until an effect is active, the user doesn't see it when opening the dropdown menu and they wouldn't necessarily know it was added either because the dropdown closes immediately after they make their selection.

So if this is possible, maybe have the "show effect" option be visible in the dropdown at all times but just in an unselectable/disabled until there is an active effect? And it probably should be at the very bottom of the effect list too.

ghost commented 4 years ago

@dshokouhi commented on Sep 5, 2019, 6:03 PM UTC:

Maybe instead of "Stop Effect" we change it to "No Effect" and make that the default option?

ghost commented 4 years ago

@iantrich commented on Sep 5, 2019, 6:51 PM UTC:

I like "No Effect". Going to add that.

ghost commented 4 years ago

@iantrich commented on Sep 6, 2019, 2:16 AM UTC:

Looked at the code and it is just a list of effects, so for now just going to have "stop" for now. It will not be hidden.

Edit: Changing my mind. Going to go with a button. That will be cleaner

ghost commented 4 years ago

@iantrich commented on Sep 6, 2019, 2:28 AM UTC:

I only have the demo light to play with for this but it has an effect of 'none'. Do yours not?

image

ghost commented 4 years ago

@dshokouhi commented on Sep 6, 2019, 2:48 AM UTC:

This is what I got:

Lightify: image

Hue: image

Limitlessled: image

ghost commented 4 years ago

@iantrich commented on Sep 6, 2019, 3:44 AM UTC:

Can you check if there is an effect attribute after calling the turn_on with an effect of "stop"?

ghost commented 4 years ago

@BjoernPetersen commented on Mar 3, 2020, 5:45 PM UTC:

As I understand the (partial) fix has been reverted in #3672, right? Could this issue be reopened then? I understand that there's no perfect solution for all devices right now, but having to power-cycle the light to turn off an effect is still annoying.

ghost commented 4 years ago

@iantrich commented on Mar 3, 2020, 7:14 PM UTC:

I don't believe this is a frontend issue. The backend would have to change to have all integrations follow a similar method of stopping effects, if even possible before the frontend could support it.

stale[bot] commented 4 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

jes1417 commented 4 years ago

Still an issue

stale[bot] commented 4 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

BjoernPetersen commented 4 years ago

Still an issue

kylian-002 commented 3 years ago

i am now stuck with a candy hue strip in my living room... seting effect: stop will just revert it back to colorloop and so nothing chnages and stays stuck at colorloop

github-actions[bot] commented 3 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

BjoernPetersen commented 3 years ago

Still an issue.

Traseus commented 3 years ago

Still an issue!

github-actions[bot] commented 3 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

BjoernPetersen commented 3 years ago

Still an issue.

lafferlaffer commented 3 years ago

Still an issue :)

RedWheiler80 commented 3 years ago

Still no solution.

sHaggYcaT commented 3 years ago

Please add it

thecode commented 3 years ago

I know some are not going to like it, but there is no point leaving this issue open. Issues are for bugs and not for feature requests, but even if we do want to support it there is no general way to support it since support for turning off an effect must be implemented by every light integration.

This is an example from Shelly which already has an Off in the list (it can be discussed later about adding a button, but that should be in the frontend repository and started by a feature request) image

The correct way to move forward with it is first to open a feature request to add an option to turn off effect here: https://community.home-assistant.io/c/feature-requests/13 Note that this needs to be done for every light integration and some of them might not be able to support it.

If you are a developer and willing to work on the frontend to add this you can open an architecture discussion here: https://github.com/home-assistant/architecture/discussions Note that discussions are only for developers who wants to implement a change in HA, not for feature requests