home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.8k stars 30.9k forks source link

elkm1 climate entity for thermostats seems broken in 0.108.3 release #34278

Closed lmamakos closed 4 years ago

lmamakos commented 4 years ago

The problem

The climate entity for ElkM1 attached thermostats seems broken in a recent version 0.108.3 with absurbdly high temperatures .

The attributes from my climate device look like:

hvac_modes:
  - 'off'
  - heat
  - cool
  - auto
  - fan_only
min_temp: 34
max_temp: 210
target_temp_step: 1
fan_modes:
  - auto
  - 'on'
current_temperature: 153
target_temp_high: 163
target_temp_low: 154
current_humidity: 0
fan_mode: auto
aux_heat: 'off'
name: Thermostat
mode: 1
hold: false
fan: 0
current_temp: 67
heat_setpoint: 68
cool_setpoint: 73
humidity: 0
index: 1
friendly_name: Thermostat
supported_features: 74

Environment

Running Home Assistant 0.108.3 in the form of the Home Assistant generated docker container, deployed in docker on Ubuntu 18.04. The Elk M1 panel is connected to Home Assistant via its Ethernet interface.

Problem-relevant configuration.yaml

elkm1:
  # host: socket://elk.farm.transsys.com:2101
  host: elk://10.200.34.200:2101
  area:
    exclude:
      - 2-8
  counter:
    include:
      - 1
      - 3
  keypad:
    exclude:
      - 4-16
  output:
    exclude:
      - 50-208
  plc:
    # yay! no more X-10 lights! yay!
    exclude:
      - a1-p16
  setting:
    include:
      - 1-20
  task:
    # tasks 16 - 32 are tied to keypad Function key buttons
    include:
      - 1-32
  thermostat:
    exclude:
      - 2-16
  zone:
    exclude:
      - 33-208

Traceback/Error logs

Additional information

Lovelace climate UI:

Screen Shot 2020-04-15 at 8 37 37 PM
probot-home-assistant[bot] commented 4 years ago

Hey there @bdraco, mind taking a look at this issue as its been labeled with a integration (elkm1) you are listed as a codeowner for? Thanks!

bdraco commented 4 years ago

I've setup a version with a potential fix can be installed in custom_components

Step 1: Add the following to your configuration.yaml

logger:
  default: info
  logs:
      custom_components.elkm1: debug

Step 2

cd /config
mkdir custom_components
cd custom_components
git clone https://github.com/bdraco/elkm1

Step 3: Restart

lmamakos commented 4 years ago

I have tested the version cloned from your git repo, and it seems to have resolved the issue. In the states developer tool, I see

hvac_modes:
  - 'off'
  - heat
  - cool
  - auto
  - fan_only
min_temp: 1
max_temp: 99
target_temp_step: 1
fan_modes:
  - auto
  - 'on'
current_temperature: 68
target_temp_high: 73
target_temp_low: 68
current_humidity: 0
fan_mode: auto
aux_heat: 'off'
name: Thermostat
mode: 1
hold: false
fan: 0
current_temp: 68
heat_setpoint: 68
cool_setpoint: 73
humidity: 0
index: 1
friendly_name: Thermostat
supported_features: 74

and Screen Shot 2020-04-16 at 11 55 40 AM

This seems to have resolved the issue with the thermostat. I'll poke around a bit further to see if anything was adversely affected.

DDomnick commented 4 years ago

Tested as well, working great. Thanks again for all you do, Nick.