home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.8k stars 30.9k forks source link

New Fritz!Box integration error with 0.109.0.b1 #34619

Closed DavidFW1960 closed 4 years ago

DavidFW1960 commented 4 years ago

The problem

I am getting an error in the log for the Fritz Integration in b1

Environment

Problem-relevant configuration.yaml

Traceback/Error logs

Log Details (ERROR)
Logger: homeassistant.core
Source: components/fritzbox/config_flow.py:120
First occurred: 8:55:48 AM (3 occurrences)
Last logged: 8:55:48 AM

Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 124, in async_init
    flow, flow.init_step, data, init_done
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 196, in _async_handle_step
    result: Dict = await getattr(flow, method)(user_input)
  File "/usr/src/homeassistant/homeassistant/components/fritzbox/config_flow.py", line 120, in async_step_ssdp
    if entry.data[CONF_HOST] == host:
KeyError: 'host'

Additional information

No devices image

DavidFW1960 commented 4 years ago

this is a f**king nightmare! I used the Terminal addon and I can get an output when I install pyfritzhome in there but I can't copy the output as text! image The error is definitely coming from the 3000 repeater. (91)

DavidFW1960 commented 4 years ago

I am running HA Supervised (on Debian) BTW.. I was trying to run the commands in a standard shell. When I ran them with the ssh community addon I got the above but I don't see any way to get the output of a command to be able to be pasted as text (it uses a zsh terminal). ALso tried to pipe it to a file and even added xclip as a package but nothing works to get the 'text'

escoand commented 4 years ago

@DavidFW1960 This is good news. It's exactly as I thought, the FRITZ!Repeaters aren't able to handle this.

Anyway, from your output I would say you don't need this integration at all. Fritzhome doesn't show any smart sensor or switch.

DavidFW1960 commented 4 years ago

Anyway, from your output I would say you don't need this integration at all. Fritzhome doesn't show any smart sensor or switch.

Correct it doesn't BUT I can't ignore the integration - I have to configure it otherwise every time HA starts it rediscovers the integration.

escoand commented 4 years ago

I've added unique_id so you could ignore with the next release. https://github.com/home-assistant/core/pull/34716

DavidFW1960 commented 4 years ago

So b5 hopefully? I'll look forward to it. Thanks.

chemelli74 commented 4 years ago

@chemelli74 Are you able to test this small fix? #34802

I can test, if you provide full file to be replaced and the path. Thx,

Simone

chemelli74 commented 4 years ago

@chemelli74 Are you able to test this small fix? #34802

I can test, if you provide full file to be replaced and the path. Thx,

Simone

Forget about it, a second restart of HA apparently solved the issue. Still on b4. Step to reproduce:

Step to fix:

Simone

Florian-Schmidt commented 4 years ago

@Florian-Schmidt Thanks for the description. Your error KeyError: host will be fixed with the referenced PR.

@escoand I wasn't sure if the PR is already included into versions I’ve been using. I now switched to latest 0.109.0 Release and hoped this will solve the message. But it's still existing, shouldn't it be solved? I'm weird...

escoand commented 4 years ago

@Florian-Schmidt Have you removed and re-added your device?

Florian-Schmidt commented 4 years ago

@escoand You mean fritz boxes or DECT climates? I guess, fritz boxes and did already during HA beta use but I can try it again.

Florian-Schmidt commented 4 years ago

@escoand Crazy, already tried during beta and after switching to 0.019.0 I've been asked to integrated boxes again. However now it seems to be working again.

By the way I updated to 0.109.1 and re-added afterwards.

escoand commented 4 years ago

Yeah, there were multiple PRs. Configuration post 0.109.0 beta should be stable and without any known issues.

Florian-Schmidt commented 4 years ago

Thanks a lot!

DavidFW1960 commented 4 years ago

I removed the integrations in 0.109.ob5 and then was able to ignore discovery on next restart and it hasn't come back since. Thanks @escoand