UI finds a forked-daapd server then can't configure it

Gordontgopher commented 4 years ago

UI discovers a forked-daapd server but fails to configure it. I don't have an itunes server on the IP address specified (The IP address is the Debian server running Home Assistant), so I used the default parameters to explore what it had found! I do have an itunes server running on a Synology NAS, but that's a different IP address. See screen grabs below. Would suggest that if it is an issue with port number or API Key then "Not a forked-daapd server." is not the most informative error message :)

Environment

Integration causing this issue: forked-daapd
Link to integration documentation on our website: https://rc.home-assistant.io/integrations/forked_daapd/

Problem-relevant `configuration.yaml`

UI Configured.

Traceback/Error logs

No log entries associated with this integration.

Additional information

probot-home-assistant[bot] commented 4 years ago

forked_daapd documentation forked_daapd source _{^{(message by IssueLinks)}}

probot-home-assistant[bot] commented 4 years ago

Hey there @uvjustin, mind taking a look at this issue as its been labeled with a integration (forked_daapd) you are listed as a codeowner for? Thanks! _{^{(message by CodeOwnersMention)}}

uvjustin commented 4 years ago

@Gordontgopher Let me look into this. Seems like a few issues: 1) The "Itunes" string should be coming from the forked-daapd library name which we get from zeroconf. Is that the name of your library? 2) There are other error messages for incorrect passwords and port numbers, but I've only tested them on my own setup. Have to back out the type of error from various aiohttp errors and http status codes when getting the server config - your setup is probably different than what I have tested against. Can you give me the json info from http://192.168.1.100:3689/api/config and the zeroconf info for _daap._tcp?

uvjustin commented 4 years ago

Not sure if this is your issue, but I had a look through the forked-daapd version history and the JSON API was a WIP throughout version 26.x. I have PRs to edit the documentation and the error strings to reflect support only for version > 27.0.

Gordontgopher commented 4 years ago

1.Yes that is the server name. 2. Can you give me the json info from http://192.168.1.100:3689/api/config ? Not found Error 404 mt-daapd: 0.2.4.1 Error: No such file or directory 2. and the zeroconf info for _daap._tcp I would happily tell you if I knew how :)

uvjustin commented 4 years ago

Thanks for the info. As it turns out, the iTunes server you have on your Synology is advertising similar information on the same protocol because the iTunes server uses Firefly Media Server, the predecessor to forked-daapd. We have identified the issue and a PR has been created to fix this.

From: Gordontgopher notifications@github.com Sent: Tuesday, May 19, 2020, 5:59 PM To: home-assistant/core Cc: uvjustin; Mention Subject: Re: [home-assistant/core] UI finds a forked-daapd server then can't configure it (#35614)

1.Yes that is the server name.

Can you give me the json info from http://192.168.1.100:3689/api/config ? Not found Error 404 mt-daapd: 0.2.4.1 Error: No such file or directory
and the zeroconf info for _daap._tcp I would happily tell you if I knew how :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/home-assistant/core/issues/35614#issuecomment-630718475, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AK7SUVO7JMO44R7BO2CCO73RSJKAPANCNFSM4NAS4YUQ.

Gordontgopher commented 4 years ago

I'm also now getting the error message "The forked-daapd integration requires a forked-daapd server with version >= 27.0." I'm happy to close this issue and wait to see if the PR helps (or I get round to updating my Synology!). Thanks for your help.

home-assistant / core