home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.8k stars 30.5k forks source link

OZW climate: mode 'off' invalid #37917

Closed firstof9 closed 4 years ago

firstof9 commented 4 years ago

The problem

Toggling HVAC mode to off results in error.

Environment

Problem-relevant configuration.yaml

n/a

Traceback/Error logs

2020-07-16 13:27:41 WARNING (MainThread) [homeassistant.components.ozw.climate] Received an invalid hvac mode: off

Additional information

When attempting to toggle the HVAC unit to off via the UI card this error was populated into the log.

probot-home-assistant[bot] commented 4 years ago

Hey there @cgarwood, @marcelveldt, @martinhjelmare, mind taking a look at this issue as its been labeled with an integration (ozw) you are listed as a codeowner for? Thanks! (message by CodeOwnersMention)

marcelveldt commented 4 years ago

Hmmm, this may happen if the device doesn't have an idle/off mode. Can you provide the mqtt dump please so I can have a look ?

kpine commented 4 years ago

I can confirm the same. The rest of the modes are working except for Off. If I set the mode to off from the thermostat itself it's reported correctly in HA.

mqtt_dump.txt

OpenZWave/2/node/5/instance/1/commandclass/64/value/89128980/

{
    "Label": "Mode",
    "Value": {
        "List": [
            {
                "Value": 0,
                "Label": "Off"
            },
            {
                "Value": 1,
                "Label": "Heat"
            },
            {
                "Value": 2,
                "Label": "Cool"
            },
            {
                "Value": 3,
                "Label": "Auto"
            },
            {
                "Value": 11,
                "Label": "Heat Econ"
            },
            {
                "Value": 12,
                "Label": "Cool Econ"
            }
        ],
        "Selected": "Heat",
        "Selected_id": 1
    },
    "Units": "",
    "ValueSet": true,
    "ValuePolled": false,
    "ChangeVerified": false,
    "Min": 0,
    "Max": 0,
    "Type": "List",
    "Instance": 1,
    "CommandClass": "COMMAND_CLASS_THERMOSTAT_MODE",
    "Index": 0,
    "Node": 5,
    "Genre": "User",
    "Help": "Set the Thermostat Mode",
    "ValueIDKey": 89128980,
    "ReadOnly": false,
    "WriteOnly": false,
    "Event": "valueChanged",
    "TimeStamp": 1594827082
}
marcelveldt commented 4 years ago

Thanks, I actually fixed this (typo) in the PR that's about to be merged. https://github.com/home-assistant/core/pull/37713/commits/c27e398e5c72bfdfa4378068f1b979a6e7879e8b

frenck commented 4 years ago

@marcelveldt Could you point me to a related PR nr?

balloob commented 4 years ago

Fixed in https://github.com/home-assistant/core/pull/37713