Sensitive data is no longer isolated when migrated from config to ui integrations.

nicxvan commented 4 years ago

The problem

I see logs mentioning that the onvif platform does not support platforms and to remove it from config. Looking further it seems it was migrated from configuration.yaml to the ui. However that means that the password is no longer isolated in the secrets.yaml and is interspersed in config. Ideally it would be separated so it can be excluded from version control.

Environment

Home Assistant Core release with the issue: .113
Last working Home Assistant Core release (if known): unknown
Operating environment (OS/Container/Supervised/Core): Container
Integration causing this issue: Onvif
Link to integration documentation on our website: https://www.home-assistant.io/integrations/onvif/

Problem-relevant `configuration.yaml`

  - platform: onvif
    host: xxx.xx.xx.xx
    name: Shed
    username: admin
    password: !secret amcrest
    port: 8999

Traceback/Error logs

The onvif platform for the camera integration does not support platform setup.

Additional information

dshokouhi commented 4 years ago

This is normal for a config flow element. All the data is stored in the .storage directory so you can and should exclude that directory which is located in your config folder.

frenck commented 4 years ago

This is by design, .storage can be used for version control, but not public as it contains sensitive data.

If you want to suggest a feature, you should try our Community Forum: Feature Requests.

If you have additional questions, feel free to join our Discord chat server.

Thanks! 👍

home-assistant / core