home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.8k stars 30.89k forks source link

Samsungtv audio doesn't update on mute #38709

Closed chemelli74 closed 4 years ago

chemelli74 commented 4 years ago

The problem

When you mute the TV, media player is not graphically updated. Custom integration HomeAssistant - SamsungTV Smart Component instead works fine.

Environment

Problem-relevant configuration.yaml

UI

Traceback/Error logs

-

Additional information

probot-home-assistant[bot] commented 4 years ago

Hey there @escoand, mind taking a look at this issue as its been labeled with an integration (samsungtv) you are listed as a codeowner for? Thanks! (message by CodeOwnersMention)

escoand commented 4 years ago

Showing a mute state is like gambling. AFAIK there is no way to request the current state of the TV. So the component could be right, but this is just a 50:50 chance.

chemelli74 commented 4 years ago

Seems custom component take the status from upnp. Can be a good point. What you think ?

Simone

escoand commented 4 years ago

Some time ago I had a PR implementing exactly this. But it was denied because the integrations are not allowed to implement the protocol directly. We need to have a library doing so, but found non.

chemelli74 commented 4 years ago

Some time ago I had a PR implementing exactly this. But it was denied because the integrations are not allowed to implement the protocol directly. We need to have a library doing so, but found non.

So you may ask the owner of the underlying lib to implement your code. Would be really nice to have the embedded component have this feature working.

Simone

Note: would be cool to use this media_player layout for audio control:

image

escoand commented 4 years ago

You can already configure this with dlna_dmr and universal media player integrations.

But it's not also not allowed to use an other integration. And reimplementing the same again is also a bit strange.

chemelli74 commented 4 years ago

You can already configure this with dlna_dmr and universal media player integrations.

Thx for the pointer

But it's not also not allowed to use an other integration.

I wanted to say that if you already have the code for the mute from the rejected PR, it should be implemented in the samsungtvws library on which default integration is based.

And reimplementing the same again is also a bit strange.

I agree, even if having the default integration working 100% and having all features should be the primary goal. So either use the external working one to replace current or add the few missing things and get the current one feature complete and completely working.

Simone

escoand commented 4 years ago

My rejected PR is https://github.com/home-assistant/core/pull/25044. The comments there say this UPNP interface is maybe not available on newer devices. So the whole work could be useless. But feel free to create an issue at samsungtvws.

FYI: https://github.com/home-assistant/core/pull/36519#issuecomment-673098657

chemelli74 commented 4 years ago

@escoand can you be so kind to point me to the mute/audio function in your PR ? Seems I cannot find it. Thx,

Simone

escoand commented 4 years ago

@chemelli74 Not sure, maybe it's not existing :D

chemelli74 commented 4 years ago

I fear that that the only way is to get it from SmartThings. I bet it's not allowed to reference an integration from another integration; am I wrong ?

Simone

escoand commented 4 years ago

Afaik yes.

chemelli74 commented 4 years ago

As there is no way to progress, I close this unresolved issue.

Simone