OVO Energy creates gas sensors when there is no gas supply information

RogerSelwyn commented 4 years ago

The problem

When there is no gas supplied, I would expect that no gas sensors would be created, since these would always be unavailable. After fixing an error related to this in the ovoenergy module, the sensors are created.

Environment

Home Assistant Core release with the issue: 0.114.0
Last working Home Assistant Core release (if known): n/a
Operating environment (OS/Container/Supervised/Core): Ubuntu/Docker/Hassio
Integration causing this issue: ovo_energy
Link to integration documentation on our website: https://www.home-assistant.io/integrations/ovo_energy/

Problem-relevant `configuration.yaml`

n/a

Traceback/Error logs

None

Additional information

See also this issue - https://github.com/home-assistant/core/issues/38805

probot-home-assistant[bot] commented 4 years ago

ovo_energy documentation ovo_energy source _{^{(message by IssueLinks)}}

frenck commented 4 years ago

@RogerSelwyn Please note, you do not have to create an issue in order to do a PR. Just the PR is OK.

probot-home-assistant[bot] commented 4 years ago

Hey there @timmo001, mind taking a look at this issue as its been labeled with an integration (ovo_energy) you are listed as a codeowner for? Thanks! _{^{(message by CodeOwnersMention)}}

RogerSelwyn commented 4 years ago

@RogerSelwyn Please note, you do not have to create an issue in order to do a PR. Just the PR is OK.

OK, thanks. Noted for future. Do you want me to close this issue?

home-assistant / core