search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.63k stars 30.78k forks source link

Why do you restart Home Assistant? #39033

Closed balloob closed 4 years ago

balloob commented 4 years ago

People talk about how they want to have the Home Assistant restart button front and center in the UI. As less and less things actually require a restart, I want to use this issue to see why people are still restarting that often.

bdraco commented 4 years ago

@DanielWe2 take a look at my PR: #39548 You should be able to create a similar PR for influxdb. It's just a matter of adding setup_reload_service(hass, DOMAIN, PLATFORMS) to setup_platform and services.yaml.

That will work for integrations that use setup_platform or async_setup_platform. For influxdb, we can reuse part of what was done for homekit.

Misiu commented 4 years ago

@bdraco I've looked at the code and I see that function: https://github.com/home-assistant/core/blob/dev/homeassistant/components/influxdb/sensor.py#L144 but I guess it isn't that easy task after all 🙂

bdraco commented 4 years ago

@bdraco I've looked at the code and I see that function: https://github.com/home-assistant/core/blob/dev/homeassistant/components/influxdb/sensor.py#L144 but I guess it isn't that easy task after all 🙂

We probably would need to do something like we did with group for this one.

balloob commented 4 years ago

As the month of WTH is coming to an end I will be closing this issue now. Thanks everybody for all the feedback.