Translations: Use references in config flow - Githubissues

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.

https://www.home-assistant.io

Apache License 2.0

73.43k stars 30.67k forks source link

Translations: Use references in config flow #40578

Closed MartinHjelmare closed 3 years ago

MartinHjelmare commented 4 years ago

The problem

Use as many references as possible, in config flow translations.
Relevant docs sections: https://developers.home-assistant.io/docs/internationalization/core#introducing-new-strings
See below for a list of all existing strings.json files that represent integration config flow translations.
Pick one integration that is not done from the list below and check its strings.json file. Replace as many strings as possible with references according to our docs. Make sure to also replace the error and abort string keys in the config_flow.py module of the integration, but not the user input data keys. Finally update tests in test_config_flow.py for the integration. Open a PR with the changes for the integration.
Here's the file with the available string references to choose from: https://github.com/home-assistant/core/blob/dev/homeassistant/strings.json
Remember to reference this issue in your PR, but don't close or fix this issue until all integrations are done.

Integrations

Environment

Home Assistant Core release with the issue: 0.115
Last working Home Assistant Core release (if known):
Operating environment (OS/Container/Supervised/Core):
Integration causing this issue:
Link to integration documentation on our website:

Problem-relevant `configuration.yaml`

Traceback/Error logs

Additional information

Spartan-II-117 commented 4 years ago

would it be possible to break out the list of incomplete integrations? maybe a complete list, an in progress list, and a not started list?

MartinHjelmare commented 4 years ago

There are only a couple of PRs in progress. So the list in the top post is more or less accurate.

Spartan-II-117 commented 4 years ago

Yeah, it's just hard to look through (visually impaired user here)

wouterbaake commented 4 years ago

https://github.com/home-assistant/core/blob/dev/homeassistant/components/ipma/strings.json https://github.com/home-assistant/core/blob/dev/homeassistant/components/sonarr/strings.json https://github.com/home-assistant/core/blob/dev/homeassistant/components/volumio/strings.json https://github.com/home-assistant/core/blob/dev/homeassistant/components/wilight/strings.json https://github.com/home-assistant/core/blob/dev/homeassistant/components/xiaomi_miio/strings.json have only references to common strings or strings that are not included in the common strings. Can be marked as done.

github-actions[bot] commented 3 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

MartinHjelmare commented 3 years ago

Closing this. Most integrations are done. We can open up individual issues for remaining work the next time we want to focus on this.

Thanks to everyone that helped with this effort! :tada:

Previous