ZHA - zhaquirks/philips issue after 0.116.0

hellcry37 commented 4 years ago

The problem

Environment

Home Assistant Core release with the issue: 0.116.0, 0.116.1, 0.116.2
Last working Home Assistant Core release (if known): 0.115.6
Operating environment (OS/Container/Supervised/Core): Ubuntu 20 LTS / Core (Docker container)
Integration causing this issue: ZHA
Link to integration documentation on our website: https://www.home-assistant.io/integrations/zha

Problem-relevant `configuration.yaml`

zha:
  zigpy_config:
    database_path: /config/zigbee.db
    device:
      path: /dev/ttyUSB0
      baudrate: 115200
    ota:
      otau_directory: /config/zigpy_ota
      ikea_provider: false
      ledvance_provider: false
    ezsp_config:
      CONFIG_APS_UNICAST_MESSAGE_COUNT: 12
      CONFIG_SOURCE_ROUTE_TABLE_SIZE: 16
      CONFIG_ADDRESS_TABLE_SIZE: 8

Traceback/Error logs

2020-10-10 18:47:42 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/zhaquirks/philips/__init__.py", line 114, in _job
    self._callback(self._click_counter)
  File "/usr/local/lib/python3.8/site-packages/zhaquirks/philips/__init__.py", line 182, in send_press_event
    event_args[PRESS_TYPE] = press_type
UnboundLocalError: local variable 'press_type' referenced before assignment

Additional information

Philips hue dimmers work but there is a delay between command and execution and ofc the errors.

dmulcahey commented 4 years ago

Will close this when I push a new version of the module to HA

hellcry37 commented 4 years ago

I am guessing this is still not in 0.116.4 because the issue is still there, in fact the zigbee network gave me a lot more fails in 0.116. As of this moment tested 0.115.6 and works very well again, switching to 0.116.x feels laggy at least. In 0.116 pushing a button on philips takes 1 second to do the action and on 0.115 is instant.

hellcry37 commented 4 years ago

tag: 0.117.0 Issue still present, latest workinh ha was 0.115.6 push button to actual light change still laggy, if + and - pressed fast enough light dont dim or brighten anymore, if i wait for action to take place then it works, errors still persist

Logger: homeassistant
Source: /usr/src/homeassistant/homeassistant/runner.py:115
First occurred: 6:51:52 PM (1 occurrences)
Last logged: 6:51:52 PM
Error doing job: Task exception was never retrieved

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/zhaquirks/philips/__init__.py", line 114, in _job
    self._callback(self._click_counter)
  File "/usr/local/lib/python3.8/site-packages/zhaquirks/philips/__init__.py", line 182, in send_press_event
    event_args[PRESS_TYPE] = press_type
UnboundLocalError: local variable 'press_type' referenced before assignment

hellcry37 commented 4 years ago

tag: 0.117.1 Issue persist.

hellcry37 commented 3 years ago

tag 0.117.5, still persist


Logger: homeassistant
Source: /usr/src/homeassistant/homeassistant/runner.py:115
First occurred: 11:41:22 PM (1 occurrences)
Last logged: 11:41:22 PM
Error doing job: Task exception was never retrieved

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/zhaquirks/philips/__init__.py", line 114, in _job
    self._callback(self._click_counter)
  File "/usr/local/lib/python3.8/site-packages/zhaquirks/philips/__init__.py", line 182, in send_press_event
    event_args[PRESS_TYPE] = press_type
UnboundLocalError: local variable 'press_type' referenced before assignment

home-assistant / core