home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.14k stars 29.81k forks source link

DenonAVR 0.9.7 breaks setup of integration if Dynamiq EQ is off #44056

Closed heikkih closed 3 years ago

heikkih commented 3 years ago

The problem

Setting up a Denon AVR-X4700H does not work after denonavr was updated to 0.9.7

See issue: https://github.com/scarface-4711/denonavr/issues/170

Environment

Problem-relevant configuration.yaml

Traceback/Error logs

  File "/usr/src/homeassistant/homeassistant/components/denonavr/config_flow.py", line 146, in async_step_confirm
    return await self.async_step_connect()
  File "/usr/src/homeassistant/homeassistant/components/denonavr/config_flow.py", line 160, in async_step_connect
    if not await connect_denonavr.async_connect_receiver():
  File "/usr/src/homeassistant/homeassistant/components/denonavr/receiver.py", line 33, in async_connect_receiver
    if not await self._hass.async_add_executor_job(self.init_receiver_class):
  File "/usr/local/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/denonavr/receiver.py", line 66, in init_receiver_class
    self._receiver = denonavr.DenonAVR(
  File "/usr/local/lib/python3.8/site-packages/denonavr/denonavr.py", line 344, in __init__
    self.update()
  File "/usr/local/lib/python3.8/site-packages/denonavr/denonavr.py", line 527, in update
    return bool(self._update_avr_2016())
  File "/usr/local/lib/python3.8/site-packages/denonavr/denonavr.py", line 644, in _update_avr_2016
    executor.submit(self._audyssey.update())
  File "/usr/local/lib/python3.8/site-packages/denonavr/audyssey.py", line 109, in update
    self.dynamiceq = bool(int(param.text))
TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'

Additional information

probot-home-assistant[bot] commented 3 years ago

denonavr documentation denonavr source (message by IssueLinks)

balloob commented 3 years ago

CC @scarface-4711

JPHutchins commented 3 years ago

@scarface-4711 we need to merge https://github.com/scarface-4711/denonavr/pull/171 and bump version to fix this.