home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.35k stars 29.89k forks source link

HomeKit initiating "vacuum.start" instead of "vacuum.turn_on" service for Deebot N79s entity. #45024

Closed dekay7 closed 3 years ago

dekay7 commented 3 years ago

The problem

When turning on my RoboVac's accessory in HomeKit, it initiates the "vacuum.start" service instead of "vacuum.turn_on" service for the Deebot N79s entity. The Deebot status does not change with the "vacuum.start" but it starts cleaning with "vacuum.turn_on".

Environment

Problem-relevant configuration.yaml

ecovacs:
  username: email
  password: password
  country: US
  continent: NA

Traceback/Error logs

none

Additional information

nope! that's literally it.

frenck commented 3 years ago

Your issue template is lacking information. Please fill out the given template as much as possible.

Without it, we can't help you.

Thanks already! 👍

dekay7 commented 3 years ago

there isn't really much to it, it is just that the homekit accessory is initiating the wrong service...

frenck commented 3 years ago

Still, please fill out the issue template. Thanks.

dekay7 commented 3 years ago

done?

probot-home-assistant[bot] commented 3 years ago

ecovacs documentation ecovacs source (message by IssueLinks)

probot-home-assistant[bot] commented 3 years ago

homekit documentation homekit source (message by IssueLinks)

bdraco commented 3 years ago
        if features & (vacuum.SUPPORT_START | vacuum.SUPPORT_RETURN_HOME):
            a_type = "DockVacuum"

The current code assumes that we should use start if SUPPORT_RETURN_HOME or SUPPORT_START

dekay7 commented 3 years ago

yes i see that, however, my deebot does support return home, but it doesn't support start. Home Assistant Vacuums refer to this link to see the service that needs to be initiated for specific robo vac brands.

dekay7 commented 3 years ago

the issue isn't fixed...

bdraco commented 3 years ago

Did you pull in the new code from the PR?

dekay7 commented 3 years ago

yes it was updated even before i setup the integration in the first place. it still doesn't work. ill fix it later locally.