Upgrade to 2021.2.1 breaks Z-Wave Thermostat "climate" entity

loganjohnlong commented 3 years ago

The problem

Upgrade from 2021.2.0 to 2021.2.1 causes the "climate" entity to show as orphaned. When excluding and re-including the device, the "climate" entity does not appear at all, even in the orphaned state. The entity can still be controlled from the OZW control panel (0.9.0) in both scenarios without issue. Other sensors associated with the thermostat show up fine in both versions, and continue to show properly after the device is excluded and re-included. The problem can be fixed by rolling back to 2021.2.0.

What is version of Home Assistant Core has the issue?

2021.2.1

What was the last working version of Home Assistant Core?

2021.2.0

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

OpenZWave (beta) 0.9.0

Link to integration documentation on our website

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

File "/usr/src/homeassistant/homeassistant/components/ozw/climate.py", line 210, in temperature_unit
    return convert_units(self._current_mode_setpoint_values[0].units)
IndexError: tuple index out of range

dshokouhi commented 3 years ago

I see this too as soon as I updated my climate entity is unavailale.

2021-02-05 10:13:10 ERROR (MainThread) [homeassistant.components.climate] Error adding entities for domain climate with platform ozw
Traceback (most recent call last):
  File "/srv/homeassistant3.8/lib/python3.8/site-packages/homeassistant/helpers/entity_platform.py", line 315, in async_add_entities
    await asyncio.gather(*tasks)
  File "/srv/homeassistant3.8/lib/python3.8/site-packages/homeassistant/helpers/entity_platform.py", line 421, in _async_add_entity
    capabilities=entity.capability_attributes,
  File "/srv/homeassistant3.8/lib/python3.8/site-packages/homeassistant/components/climate/__init__.py", line 189, in capability_attributes
    self.hass, self.min_temp, self.temperature_unit, self.precision
  File "/srv/homeassistant3.8/lib/python3.8/site-packages/homeassistant/components/climate/__init__.py", line 498, in min_temp
    DEFAULT_MIN_TEMP, TEMP_CELSIUS, self.temperature_unit
  File "/srv/homeassistant3.8/lib/python3.8/site-packages/homeassistant/components/ozw/climate.py", line 210, in temperature_unit
    return convert_units(self._current_mode_setpoint_values[0].units)
IndexError: tuple index out of range

FYI: @Chrisgozd

probot-home-assistant[bot] commented 3 years ago

ozw documentation ozw source _{^{(message by IssueLinks)}}

probot-home-assistant[bot] commented 3 years ago

Hey there @cgarwood, @marcelveldt, @martinhjelmare, mind taking a look at this issue as its been labeled with an integration (ozw) you are listed as a codeowner for? Thanks! _{^{(message by CodeOwnersMention)}}

dshokouhi commented 3 years ago

If I revert the changes for temperature_unit and current_temperature the entity is no longer unavailable not sure if anything else works as I have not tested it yet. I have a honeywell zwave thermostat which did not have any issues until this release.

https://github.com/home-assistant/core/pull/45369

Edit: thermostat is still functional from HA including temp changes