Amcrest integration doesn't work on macOS

[ahknight]

The problem

When I try to use the Amcrest integration on macOS, I get an error about undefined attributes.

What is version of Home Assistant Core has the issue?

core-2021.3.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Core

Integration causing the issue

Amcrest

Link to integration documentation on our website

https://www.home-assistant.io/integrations/amcrest/

Example YAML snippet

# Put your YAML below this line
amcrest:
  - host: garage-camera.lan
    username: !secret amcrest_user
    password: !secret amcrest_password

Anything in the logs that might be useful for us?

# Put your logs below this line
Logger: homeassistant.setup
Source: components/amcrest/__init__.py:7 
First occurred: 1:39:32 PM (1 occurrences) 
Last logged: 1:39:32 PM

Setup failed for amcrest: unknown error
Traceback (most recent call last):
  File "/Users/ahknight/.virtualenvs/hass/lib/python3.8/site-packages/homeassistant/setup.py", line 166, in _async_setup_component
    component = integration.get_component()
  File "/Users/ahknight/.virtualenvs/hass/lib/python3.8/site-packages/homeassistant/loader.py", line 491, in get_component
    cache[self.domain] = importlib.import_module(self.pkg_path)
  File "/usr/local/var/pyenv/versions/3.8.1/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/Users/ahknight/.virtualenvs/hass/lib/python3.8/site-packages/homeassistant/components/amcrest/__init__.py", line 7, in <module>
    from amcrest import AmcrestError, Http, LoginError
  File "/Users/ahknight/.virtualenvs/hass/lib/python3.8/site-packages/amcrest/__init__.py", line 14, in <module>
    from .http import Http
  File "/Users/ahknight/.virtualenvs/hass/lib/python3.8/site-packages/amcrest/http.py", line 53, in <module>
    (socket.IPPROTO_TCP, socket.TCP_KEEPIDLE, KEEPALIVE_IDLE),
AttributeError: module 'socket' has no attribute 'TCP_KEEPIDLE'

Works on Linux. I presume it's a porting issue and that support for that socket option just needs to be tested before being requested.

[probot-home-assistant[bot]]

amcrest documentation amcrest source _{^{(message by IssueLinks)}}

[probot-home-assistant[bot]]

Hey there @pnbruckner, mind taking a look at this issue as its been labeled with an integration (amcrest) you are listed as a codeowner for? Thanks! _{^{(message by CodeOwnersMention)}}

[ahknight]

FWIW, I commented out that line and that's enough to let it work. Probably not the ideal solution, but that's the only issue.

[pnbruckner]

That was fixed in amcrest package release 1.7.1 back on April 19, 2020. Unfortunately the integration's manifest.json file was never updated to use that new version; it still specifies 1.7.0. I'd think it would be a simple change to resolve this issue. You might try changing the file temporarily yourself (I mean in your installation) to see if it resolves the issue for you.

[ahknight]

Yes, it does. So how do we go about updating that manifest file?

[pnbruckner]

I'll work on it.

[pnbruckner]

@ahknight, looks like the fix is in 2021.3.2.

[ahknight]

Thanks!