search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
70.45k stars 29.38k forks source link

Xiaomio Miio - Xiaomi Fan dmaker.fan.1c #48920

Closed johnjoemorgan closed 3 years ago

johnjoemorgan commented 3 years ago

Checklist

I have updated to the latest available Home Assistant version. I have cleared the cache of my browser. I have tried a different browser to see if it is related to my browser.

Describe the issue you are experiencing

Xiaomi Fan dmaker.fan.1c missing for new config flow. Error given is: " The device model is not known, not able to setup the device using config flow. "

I had the custom component with that fan and a zhimi.fan.sa1and both working. The zhimi.fan.sa1 still works ( list as the zhimi.airpurifier.sa1in the config set up???)

How do we add the dmaker.fa.1c and other similar Xiaomi dmaker fans?

Describe the behavior you expected

The integration should have the DMaker fan series available

Steps to reproduce the issue

1.Have Xiaomi Miio Custom Components installed pre core-2021.4.x 2.Have Xiaomi Fan dmaker.fan.1c fan working with custom component 3.Update to HA 2021.4.x and unable to integrate Xiaomi Fan dmaker.fan.1c ...

What version of Home Assistant Core has the issue?

core-2021.4.1

What was the last working version of Home Assistant Core?

core-2021.3.4

In which browser are you experiencing the issue with?

Firefox V87

Which operating system are you using to run this browser?

Windows 10

State of relevant entities

# Paste your state here.

Problem-relevant frontend configuration

# Paste your YAML here.

Javascript errors shown in your browser console/inspector

# Paste your logs here.
probot-home-assistant[bot] commented 3 years ago

xiaomi_miio documentation xiaomi_miio source (message by IssueLinks)

probot-home-assistant[bot] commented 3 years ago

Hey there @rytilahti, @syssi, @starkillerog, mind taking a look at this issue as its been labeled with an integration (xiaomi_miio) you are listed as a codeowner for? Thanks! (message by CodeOwnersMention)

starkillerOG commented 3 years ago

@johnjoemorgan to clear things up: What is the actual model of the "zhimi.fan.sa1"/"zhimi.airpurifier.sa1"? The one reported by python-miio in the info call? Did the "zhimi.fan.sa1"/"zhimi.airpurifier.sa1" setup without any error, or did you also get the unknown model error and then manually selected the "zhimi.airpurifier.sa1"?

Then concerning the "dmaker.fan.1c" how did you have it working before? Was it with the official integration and a yaml config (if yes, please post the config), or did u use a custom component (if yes which one exactly)?

johnjoemorgan commented 3 years ago

@johnjoemorgan to clear things up: What is the actual model of the "zhimi.fan.sa1"/"zhimi.airpurifier.sa1"? The one reported by python-miio in the info call? Did the "zhimi.fan.sa1"/"zhimi.airpurifier.sa1" setup without any error, or did you also get the unknown model error and then manually selected the "zhimi.airpurifier.sa1"?

Then concerning the "dmaker.fan.1c" how did you have it working before? Was it with the official integration and a yaml config (if yes, please post the config), or did u use a custom component (if yes which one exactly)?

johnjoemorgan commented 3 years ago

@johnjoemorgan to clear things up: What is the actual model of the "zhimi.fan.sa1"/"zhimi.airpurifier.sa1"? The one reported by python-miio in the info call? Did the "zhimi.fan.sa1"/"zhimi.airpurifier.sa1" setup without any error, or did you also get the unknown model error and then manually selected the "zhimi.airpurifier.sa1"? Then concerning the "dmaker.fan.1c" how did you have it working before? Was it with the official integration and a yaml config (if yes, please post the config), or did u use a custom component (if yes which one exactly)?

johnjoemorgan commented 3 years ago

I reverted back to core-2021.3.x due to this and issues over the Spotcast component not working. Taking your points in order:

What is the actual model of the "zhimi.fan.sa1"/"zhimi.airpurifier.sa1"?

NAME: Fanny ID: 721xxxxx IP: 192.168.0.xxx TOKEN: 1b927ff6f MODEL: zhimi.fan.sa1

The one reported by python-miio in the info call?

Did not appear in the zhimi.fan.sa1 call but it worked straight after upgrade. I assume you used the airpurifyer prefix form the fan????

Did the "zhimi.fan.sa1"/"zhimi.airpurifier.sa1" setup without any error

Yes - see above

, or did you also get the unknown model error and then manually selected the "zhimi.airpurifier.sa1"?

Did not try that but see below

Then concerning the "dmaker.fan.1c" how did you have it working before? Was it with the official integration and a yaml config (if yes, please post the config), or did u use a custom component (if yes which one exactly)?

Yes - Custom components - https://github.com/syssi

Note the Dmaker fan is included in the

https://github.com/syssi/xiaomi_airpurifier

and not

https://github.com/syssi/xiaomi_fan

Token info for Dmaker:

NAME: Aunt Fanny ID: 2404xxxxx IP: 192.168.0.xxx TOKEN: 8254xxxxxxxxxxe65e2 MODEL: dmaker.fan.1c

Note: Tried adding the Dmaker as an air purifier and the integration completed but the device/entity was unusable

If you need me to upgrade again to replicate and screenshot willing to do so. I'm in Asia/PH UTC8. Upgrade takes about 20min for the DB move.

starkillerOG commented 3 years ago

Alright I see, I think @syssi is working on refactoring the fan platfrom and splitting out the humidifiers from the fans, he might know why these models are not implemented yet and might be willing to do so.

syssi commented 3 years ago

This is more or less a feature request and not an issue of the HA core. Please create an issue at the custom components.