home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.54k stars 30.35k forks source link

Flux_LED functionality limited #49219

Closed Crono141 closed 3 years ago

Crono141 commented 3 years ago

The problem

The Flux_LED for magiclight/magichome bulbs seems to only partially work. The module detects the available bulbs, and can turn it on and off. Brightness, color temp, active color, and white balance controls do not work. Color effects only partially work. They either operate very slowly, or only the initial state of the effect gets applied without dynamic changes. If I had to venture a guess, it seems that HomeAssistant is not providing updates to the bulb in real time when changed in the UI.

My bulb works fine with the Magic Light android app, as well as with the newer MagicHome app. I have tried using autodetect, as well as manually specifying IP address. I have also switched to the ledenet protocol to see if this would help (it didn't).

There is no branding on my bulbs, only an RGBW Wifi graphic, with a green insulation ring at the base of the screw.

I can help troubleshoot the issue. Thanks.

What is version of Home Assistant Core has the issue?

core-2021.4.4

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Flex_LED

Link to integration documentation on our website

https://www.home-assistant.io/integrations/flux_led/

Example YAML snippet

# Example configuration.yaml entry
light:
  - platform: decora_wifi
    username: ******
    password: ******
light:
  - platform: flux_led
    devices:
        192.168.1.11:
            name: "Joels Bedside Table"
            protocol: "ledenet"

Anything in the logs that might be useful for us?

Nothing I could see
icemanch commented 3 years ago

Code is being worked on to fix it. One of the problems is that not everyone has the bulbs to test with. Can you use "flux_led -sSti" on the command line and see what comes back?

Crono141 commented 3 years ago

Well, strangest thing is I can't seem to add the bulbs back to Home Assistant anymore, even copying the above yaml (with updated IP addresses). I've worked around the issue by connecting the bulbs to SmartThings, and then controlling smartthings through Home Assistant. This actually works pretty well for a lot of other trouble devices as well.

icemanch commented 3 years ago

The command I listed doesn't require them to be connected to Home Assistant. It's the actual API that home assistant is connecting to.

Glad you got it working. It could still be helpful if you can run the command but, not a big deal if you don't have time.

Thanks

Crono141 commented 3 years ago

Command returned an error. Bad command. So I thought I needed to have the bulb connected.

Specifically: Error: unknown command "flux_led" for "ha" FATA[0000] Error while executing rootCmd: unknown command "flux_led" for "ha"

github-actions[bot] commented 3 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

mattboy9921 commented 3 years ago

I can tell you right now it does not look like any progress has been made on the source code for this integration. Therefore I think it's safe to assume these issues still persist.

icemanch commented 3 years ago

I can tell you right now it does not look like any progress has been made on the source code for this integration. Therefore I think it's safe to assume these issues still persist.

Sorry, about that. I've been out for a month or two now. I'm back now and I'm working on these now. I have the code done just needs a bit of testing and the pubishing.

icemanch commented 3 years ago

I can tell you right now it does not look like any progress has been made on the source code for this integration. Therefore I think it's safe to assume these issues still persist.

@Crono141 The module has been updated and the Pull Request is being submitted. If you'd like to test that would be a big help.

https://github.com/icemanch/core/tree/Flux_LED_Update

mattboy9921 commented 3 years ago

@icemanch I'm not sure exactly how I go about testing it, but I did notice that the PR had been closed now. Is there any documentation on how I can test this to help get the PR back up and going?

icemanch commented 3 years ago

@icemanch I'm not sure exactly how I go about testing it, but I did notice that the PR had been closed now. Is there any documentation on how I can test this to help get the PR back up and going?

I had to break the request into smaller pieces to make it easier for review. There are three pieces.

  1. Update Flux_LED to config Flow (let's you configure the integrations through the US rather then YAML)
  2. Update Flux_LED to use SUPPORTED_COLOR_MODES /COLOR_MODE
  3. Update Flux_LED functionality <<< This is the one you need/want.

The review takes longer than I thought. I might try setting up a repo so that a development version can be used in HACs while we wait for the code to be added to the official code base.

The current pull request is here -> https://github.com/home-assistant/core/pull/56354

mattboy9921 commented 3 years ago

I'd definitely be down for a HACS version to test with. Let me know if you get that set up.

And thank you for your hard work on this, even just checking out the first PR, didn't realize how much is involved.

bdraco commented 3 years ago

@icemanch can we mark this fixed via #56354?

icemanch commented 3 years ago

@icemanch can we mark this fixed via #56354?

I think it should be left open for now. #56354 will make this work better but, it's not great. I'm putting the next PR together right now and should have it up by tomorrow.