Here Travel Time component uses deprecated protocol

jugla commented 3 years ago

The problem

Here Travel Time component uses HERE V3 protocol whereas it is requested to go to V8. This V3 protocol ends at 2021's end. In a deeper way, in manifest.json , the library herepy==2.0.0 is requested. The author of this library proposes the V8 in version 3.5.0 .

What is version of Home Assistant Core has the issue?

2021.4.6

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Core

Integration causing the issue

here_travel_time

Link to integration documentation on our website

https://www.home-assistant.io/integrations/here_travel_time/

Example YAML snippet

- platform: here_travel_time
    name: Home_CommercialCenter_Here_Public_Transportation
    api_key: "xxxxxxxxxxxxxxxxxxx"
    origin_latitude: "48.78096880214132"
    origin_longitude: "2.286129562173117"
    destination_latitude: "48.78521934715194"
    destination_longitude: "2.2160861252742228"
    scan_interval: 1500
    mode: publicTransportTimeTable
    traffic_mode: true

Anything in the logs that might be useful for us?

No response

Additional information

Here the official mail from HERE :

Dear Developer,

You have been identified using deprecated Transit APIs, one or multiple ways:

using transit.api.here.com
using route.api.here.com with mode=publicTransport
using route.api.here.com with mode=publicTransportTimeTable

Above methods of accessing Transit APIs are in maintenance, soon to be deprecated and ultimately going to be decommissioned, latest by end of this year (2021). We kindly ask you to migrate to new unified Transit API V8 to avoid downtime.

Here are few materials and resources our team prepared that can help you:

Documentation of the Transit APIs V8 https://developer.here.com/documentation/public-transit/dev_guide/index.html
Migration guide transit V3 -> V8 https://developer.here.com/documentation/public-transit/migration_guide/index.html
Migration guide routing V7 -> V8 https://developer.here.com/documentation/routing-api/8.21.6/migration_guide/index.html

Best regards, HERE Transit routing team

HERE Europe B.V. Kennedyplein 222-226 5611 ZT Eindhoven, The Netherlands

probot-home-assistant[bot] commented 3 years ago

here_travel_time documentation here_travel_time source _{^{(message by IssueLinks)}}

probot-home-assistant[bot] commented 3 years ago

Hey there @eifinger, mind taking a look at this issue as its been labeled with an integration (here_travel_time) you are listed as a codeowner for? Thanks! _{^{(message by CodeOwnersMention)}}

eifinger commented 3 years ago

Thank you for opening a detailed issue. I already got contacted via Twitter regarding this. I will update the integration and also add a config flow.

jugla commented 3 years ago

Thank you !

jugla commented 3 years ago

NB : respect to probot-home-assistant question, I'm the codeowner of worldtidesinfocustom

github-actions[bot] commented 3 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

eifinger commented 3 years ago

I want https://github.com/home-assistant/core/pull/51552 merged before working on this issue to reduce the amount of breaking changes

github-actions[bot] commented 2 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

eifinger commented 2 years ago

Still active

eifinger commented 2 years ago

[x] Cleanup tests https://github.com/home-assistant/core/pull/60529
[x] Use find_coordinates https://github.com/home-assistant/core/pull/59938
[x] Use DataUpdateCoordinator https://github.com/home-assistant/core/pull/61398
[x] Add a config flow with no breaking changes https://github.com/home-assistant/core/pull/69212
[x] Breaking Change: Split up the attributes in different sensors https://github.com/home-assistant/core/pull/72405
[x] Make use of SensorDeviceClass https://github.com/home-assistant/core/pull/79159
[x] Make use of the v8 HERE api https://github.com/home-assistant/core/pull/80892
[x] Make Travel Time entities extend RestoreEntity https://github.com/home-assistant/core/pull/82400
[ ] Use strict typing https://github.com/home-assistant/core/pull/83814

scottgrobinson commented 1 year ago

@eifinger Are you still working on this one? Do you have a list of outstanding tasks that you might be happy for someone else to pickup to assist with?

eifinger commented 1 year ago

Yup I'm still working on it and have the PR lined up but am waiting for https://github.com/home-assistant/core/pull/79159

scottgrobinson commented 1 year ago

Thanks - Didn't noticed that linked, much appreciated.

home-assistant / core