search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.14k stars 29.82k forks source link

Denon integration broken after update to 2021.6.4 #51778

Closed BebeMischa closed 3 years ago

BebeMischa commented 3 years ago

The problem

Denon AVR integration stopped working. Can't connect to the receiver. (HEOS still works and shows played media correctly)

Tryed:

  1. Unplugging receiver from power source. No succes.
  2. Restarting home network router. No succes.
  3. Remove integration and install again. No succes.

After removing the integration and HA restart the AVR is discovered by autosearch for new integrations. But when saying YES, install - result is: Can't connect.

On 2021.6.3 it worked fine.

More user affected, as seen here: https://community.home-assistant.io/t/2021-6-a-little-bit-of-everything/312796/470?u=bebemischa

What is version of Home Assistant Core has the issue?

2021.6.4

What was the last working version of Home Assistant Core?

2021.6.3

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

Denon AVR

Link to integration documentation on our website

https://www.home-assistant.io/integrations/denonavr/

Example YAML snippet

No response

Anything in the logs that might be useful for us?

2021-06-12 16:12:07 WARNING (MainThread) [homeassistant.config_entries] Config entry 'Denon AVR' for denonavr integration not ready yet: NetworkError: Server disconnected while attempting read; Retrying in background

Additional information

After a rollback to 2021.6.3 everything works again My receiver: AVR-X3600H

undulattice commented 3 years ago

Same issue here.

probot-home-assistant[bot] commented 3 years ago

denonavr documentation denonavr source (message by IssueLinks)

probot-home-assistant[bot] commented 3 years ago

Hey there @scarface-4711, @starkillerog, mind taking a look at this issue as its been labeled with an integration (denonavr) you are listed as a codeowner for? Thanks! (message by CodeOwnersMention)

VictorvandenHoven commented 3 years ago

Unfortunately I have exactly the same problem with my Denon S950h and HA 6.4

pergolafabio commented 3 years ago

Same here on avrx4000

michaelstein60 commented 3 years ago

Add me to the list. Denon broke on update to 2021.6.4

dwbrock62 commented 3 years ago

Same issue here. Integration with Marantz AVR broken with lastest upgrade.

denonavr integration not ready yet: TimeoutException

doug-hoffman commented 3 years ago

Same problem, X8500H on factory firmware. Confirmed rolling back to .3 resolves.

pergolafabio commented 3 years ago

Guys, any idea what component is causing the issue?

BebeMischa commented 3 years ago

I only found on the release notes, that someone was working in the neighborhood... if it helps...

image

pergolafabio commented 3 years ago

Is that in rls notes from .4 ?

BebeMischa commented 3 years ago

https://www.home-assistant.io/blog/2021/06/02/release-20216/#release-202164---june-11

pergolafabio commented 3 years ago

Strange, I don't see anything changes in .4 specific about denon

undulattice commented 3 years ago

Strange, I don't see anything changes in .4 specific about denon

It's in the "Other Breaking Changes" section.

BebeMischa commented 3 years ago

It's under "Other breaking changes"

doug-hoffman commented 3 years ago

Nothing changed in denonavr .3 -> .4 (https://github.com/home-assistant/core/compare/2021.6.3...2021.6.4). I'm not using any of the components that did change (onvif/ovo_energy/plex/samsungtv/shelly/sonos).

pergolafabio commented 3 years ago

Nothing changed in denonavr .3 -> .4 (2021.6.3...2021.6.4). I'm not using any of the components that did change (onvif/ovo_energy/plex/samsungtv/shelly/sonos).

Indeed ,that's why it's strange

undulattice commented 3 years ago

Is it possible the denonavr was mistakenly downgraded? Similar problem existed in 0.9.7 back in December '20.

https://github.com/home-assistant/core/pull/44194

pergolafabio commented 3 years ago

Easy to test, we can load it as a custom component... From .3 release

doug-hoffman commented 3 years ago

Is it possible the denonavr was mistakenly downgraded?

None of the requirements changed, even in other components.

pascalwinters commented 3 years ago

Same issue here since core-2021.6.4

mythbuster74 commented 3 years ago

Same on x3600h, just upgraded yesterday

Retrying setup: NetworkError: Server disconnected while attempting read
doug-hoffman commented 3 years ago

Found the problem... httpcore 0.13.4, released 3 days ago. If you downgrade to 0.13.3, denonavr works again. Looks like someone already reported the issue in encode/httpcore#357.

mythbuster74 commented 3 years ago

Found the problem... httpcore 0.13.4, released 3 days ago. If you downgrade to 0.13.3, denonavr works again. Looks like someone already reported the issue in encode/httpcore#357.

Going back to 0.13.3 worked for me too

pascalwinters commented 3 years ago

Found the problem... httpcore 0.13.4, released 3 days ago. If you downgrade to 0.13.3, denonavr works again. Looks like someone already reported the issue in encode/httpcore#357.

Going back to 0.13.3 worked for me too

How can you downgrade to 0.13.3?

doug-hoffman commented 3 years ago

How can you downgrade to 0.13.3?

I'm not aware of an easy way to do this when you're running on Home Assistant OS.

If you're running on docker or in a virtual env, you can use pip3 install httpcore==0.13.3 in the same environment HA runs in to temporarily downgrade. HA will attempt to upgrade again at some point, presumably the next time you upgrade HA, since this doesn't affect version requirements.

KrzysztofHajdamowicz commented 3 years ago

Jumping into the train, AVR-X2100W

HA logs:

~ $ grep denon config/home-assistant.log
2021-06-12 21:37:26 DEBUG (MainThread) [homeassistant.components.ssdp] Discovered denonavr at http://192.168.1.96:8080/description.xml
2021-06-12 21:38:12 DEBUG (MainThread) [homeassistant.components.websocket_api.http.connection] [140137038721472] Sending {"id": 66, "type": "result", "success": true, "result": [{"flow_id": "023059eed39b400cbcb30be5fd2523cb", "handler": "denonavr", "context": {"source": "ssdp", "unique_id": "AVR-X2100W-0005CD454496", "title_placeholders": {"name": "Denon AVR-X2100W"}, "confirm_only": true}, "step_id": "confirm"}]}
2021-06-12 21:38:12 DEBUG (MainThread) [homeassistant.components.websocket_api.http.connection] [140137038721472] Received {'type': 'manifest/get', 'integration': 'denonavr', 'id': 69}
2021-06-12 21:38:12 DEBUG (MainThread) [homeassistant.components.websocket_api.http.connection] [140137038721472] Sending {"id": 69, "type": "result", "success": true, "result": {"domain": "denonavr", "name": "Denon AVR Network Receivers", "config_flow": true, "documentation": "https://www.home-assistant.io/integrations/denonavr", "requirements": ["denonavr==0.10.8"], "codeowners": ["@scarface-4711", "@starkillerOG"], "ssdp": [{"manufacturer": "Denon", "deviceType": "urn:schemas-upnp-org:device:MediaRenderer:1"}, {"manufacturer": "DENON", "deviceType": "urn:schemas-upnp-org:device:MediaRenderer:1"}, {"manufacturer": "DENON PROFESSIONAL", "deviceType": "urn:schemas-upnp-org:device:MediaRenderer:1"}, {"manufacturer": "Marantz", "deviceType": "urn:schemas-upnp-org:device:MediaRenderer:1"}, {"manufacturer": "Denon", "deviceType": "urn:schemas-upnp-org:device:MediaServer:1"}, {"manufacturer": "DENON", "deviceType": "urn:schemas-upnp-org:device:MediaServer:1"}, {"manufacturer": "DENON PROFESSIONAL", "deviceType": "urn:schemas-upnp-org:device:MediaServer:1"}, {"manufacturer": "Marantz", "deviceType": "urn:schemas-upnp-org:device:MediaServer:1"}, {"manufacturer": "Denon", "deviceType": "urn:schemas-denon-com:device:AiosDevice:1"}, {"manufacturer": "DENON", "deviceType": "urn:schemas-denon-com:device:AiosDevice:1"}, {"manufacturer": "DENON PROFESSIONAL", "deviceType": "urn:schemas-denon-com:device:AiosDevice:1"}, {"manufacturer": "Marantz", "deviceType": "urn:schemas-denon-com:device:AiosDevice:1"}], "iot_class": "local_polling", "is_built_in": true}}
2021-06-12 21:38:16 DEBUG (MainThread) [denonavr.decorators] Network error exception on request <Request('GET', 'http://192.168.1.96/goform/Deviceinfo.xml')>
  File "/usr/local/lib/python3.8/site-packages/denonavr/decorators.py", line 44, in wrapper
  File "/usr/local/lib/python3.8/site-packages/denonavr/api.py", line 85, in async_get
2021-06-12 21:38:18 DEBUG (MainThread) [denonavr.decorators] Exception NetworkError: Server disconnected while attempting read raised, clearing cache
2021-06-12 21:38:18 DEBUG (MainThread) [denonavr.foundation] Connection error on port 80 when identifying receiver
  File "/usr/local/lib/python3.8/site-packages/denonavr/decorators.py", line 44, in wrapper
  File "/usr/local/lib/python3.8/site-packages/denonavr/api.py", line 85, in async_get
  File "/usr/local/lib/python3.8/site-packages/denonavr/foundation.py", line 132, in async_identify_receiver
  File "/usr/local/lib/python3.8/site-packages/denonavr/decorators.py", line 96, in wrapper
  File "/usr/local/lib/python3.8/site-packages/denonavr/decorators.py", line 44, in wrapper
  File "/usr/local/lib/python3.8/site-packages/denonavr/api.py", line 139, in async_get_xml
  File "/usr/local/lib/python3.8/site-packages/denonavr/decorators.py", line 64, in wrapper
denonavr.exceptions.AvrNetworkError: NetworkError: Server disconnected while attempting read

HassOS 6.0, Home Assistant 2021.6.4

nickrout commented 3 years ago

Downgrading httpcore to 0.13.3 did not fix this for me.

nerdosity commented 3 years ago

Broken for me too. On my latest update it was working, even if it spammed the error log continuosly.

Now it's just dead.

Logger: homeassistant.config_entries Source: config_entries.py:324 First occurred: 3:04:43 (1 occurrences) Last logged: 3:04:43

Config entry 'DENON AVR-2113' for denonavr integration not ready yet: TimeoutException: ; Retrying in background

motamedn commented 3 years ago

Hopefully, this helps. I found this in my logs after removing and failing to re-add the integration:

Logger: denonavr.ssdp
Source: /usr/local/lib/python3.8/site-packages/denonavr/ssdp.py:214
First occurred: 7:07:07 PM (1 occurrences)
Last logged: 7:07:07 PM

Error occurred during evaluation of SCPD XML from URI http://192.168.0.191:9080: not well-formed (invalid token): line 1, column 6
madAndroid commented 3 years ago

Same here, downgrading to 2021.6.3 fixed the issue

robertboccia commented 3 years ago

Same on 3400 and 3500 models

nickrout commented 3 years ago

"Me too" comments do not help solve the issue. Logs help solve the issue.

GHSTUDIO1 commented 3 years ago

Same here, downgrading to 2021.6.3 fixed the issue

I'm running under debian/docker. How do I downgrade?

doug-hoffman commented 3 years ago

I'm running under debian/docker. How do I downgrade?

You may be able to execute pip3 install httpcore==0.13.3 (possibly pip instead of pip3) inside the container to downgrade only httpcore, then restart the container for it to take effect.

If you have a snapshot/backup, you can restore that, which is what I suspect everyone else did to "downgrade". Downgrading home assistant alone probably won't fix, because it'll still want to use the new broken httpcore version. You can try downgrading using ha core update --version 2021.6.3.

GHSTUDIO1 commented 3 years ago

After I posted, I looked for an old backup and found 6.3…..I restored just 6.3, nothing else and now I’m back fully operational….thanks to everyone on this thread.

From: Doug Hoffman @.*** Sent: Sunday, June 13, 2021 9:39 AM To: home-assistant/core Cc: GHSTUDIO1; Comment Subject: Re: [home-assistant/core] Denon integration broken after update to 2021.6.4 (#51778)

I'm running under debian/docker. How do I downgrade?

You may be able to execute pip3 install httpcore==0.13.3 (possibly pip instead of pip3) inside the container to downgrade only httpcore, then restart the container for it to take effect.

If you have a snapshot/backup, you can restore that, which is what I suspect everyone else did to "downgrade". Downgrading home assistant alone probably won't fix, because it'll still want to use the new broken httpcore version. You can try downgrading using ha core update --version 2021.6.3.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/51778#issuecomment-860212570 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ALT3EX4EPHN3AWK6JAAB5MDTSSYF5ANCNFSM46SZAZGA . https://github.com/notifications/beacon/ALT3EX5VRUUX3R3HRL5ADADTSSYF5A5CNFSM46SZAZGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGNC42WQ.gif

nerdosity commented 3 years ago

pip3 install httpcore==0.13.3

It worked for me. Denon integration is back

marima84 commented 3 years ago

Same problem here with core-2021.6.4 and supervisor-2021.06.0 and denon x1400h. I'll try downgrade to 6.3. Thanks for suggestions

EDIT: downgrade to 6.3 fixed the issue

Mark