home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.59k stars 29.91k forks source link

Video Doorbell Battery does not show up #55302

Closed Travisco29 closed 2 years ago

Travisco29 commented 3 years ago

The problem

The new doorbell battery that i just got does not show up in any form in home assistant, would it be possible to add things such as button pressed to HA?

What is version of Home Assistant Core has the issue?

core-2021.8.8

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

nest

Link to integration documentation on our website

https://www.home-assistant.io/integrations/nest/

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

probot-home-assistant[bot] commented 3 years ago

nest documentation nest source (message by IssueLinks)

probot-home-assistant[bot] commented 3 years ago

Hey there @allenporter, mind taking a look at this issue as it has been labeled with an integration (nest) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

allenporter commented 3 years ago

@Travisco29 When adding a new device, typically you need to go through the re-authorization flow and give home assistant access to the device. Does this device show up in the OAuth consent screen?

allenporter commented 3 years ago

I saw some discussion on home assistant discord that sounds relevant:

Just got off the phone with Google Nest support...  was able to get confirmation that they do plan on adding support for the Nest Doorbell (battery) into the Smart Device Management API. Unfortunately they were unable to give a timeline as to when they will fully support the new devices released this week.

We can check back if any additional modifications are needed to support this once it is added to the API by Google. Hopefully it'll just work, otherwise happy to add support.

Travisco29 commented 3 years ago

Yeah when i reauth it does not show up. I will try again in a month or so and let you know

On Thu, Aug 26, 2021 at 5:07 PM Allen Porter @.***> wrote:

I saw some discussion on home assistant discord that sounds relevant:

Just got off the phone with Google Nest support... was able to get confirmation that they do plan on adding support for the Nest Doorbell (battery) into the Smart Device Management API. Unfortunately they were unable to give a timeline as to when they will fully support the new devices released this week.

We can check back if any additional modifications are needed to support this once it is added to the API by Google. Hopefully it'll just work, otherwise happy to add support.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/55302#issuecomment-906823472, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKHQIIPRQDZ7FBQAXDQKQSLT63JKJANCNFSM5C4KRBBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

kevmang commented 3 years ago

I just installed one. The Nest API requires the Doorbell to be setup in the home.nest.com dashboard. Hopefully as stated above Google will allow the Nest Doorbell (battery) to be added to the home.nest.com portal. Screenshot below so you know what I'm referring to. 2021-08-28 17_28_04-Start

thingwithstuff commented 2 years ago

I saw some discussion on home assistant discord that sounds relevant:

Just got off the phone with Google Nest support...  was able to get confirmation that they do plan on adding support for the Nest Doorbell (battery) into the Smart Device Management API. Unfortunately they were unable to give a timeline as to when they will fully support the new devices released this week.

We can check back if any additional modifications are needed to support this once it is added to the API by Google. Hopefully it'll just work, otherwise happy to add support.

Looks like it has been added https://developers.google.com/nest/device-access/api/doorbell

allenporter commented 2 years ago

What do you see on that page? I'm not yet seeing a change.

etamtlosz commented 2 years ago

I don't know when was the last major update, but back in May there was way less info than now. https://web.archive.org/web/20210521070741/https://developers.google.com/nest/device-access/api/doorbell

allenporter commented 2 years ago

When you reauthenticate with Nest, are you the device and able to authorize access to it?

Does.it show up in HA?

I don't see any updates.about battery doorbell cam on that page, but I'm on mobile and missed it. Maybe you can quote what you're referring to. Release notes.last updated in July: https://developers.google.com/nest/device-access/release-notes

kevmang commented 2 years ago

Unfortunately according to thingwithstuff the information about the addition of the Video Doorbell (Battery) was given verbally.... I guess we'll just have to wait and see!

kelstone commented 2 years ago

Good news! They updated the release notes and Supported Devices page yesterday. I just authorized access to my battery camera and reloaded the Nest Integration in HA and the camera was added properly.

September 21, 2021 Support added for the Nest Cam (outdoor or indoor, battery) and Nest Doorbell (battery)

https://developers.google.com/nest/device-access/release-notes https://developers.google.com/nest/device-access/supported-devices

UPDATE: I have not been able to get it to display video yet - the supported devices page does note the stream is WebRTC vs RSTP for what that's worth.

scottjones4k commented 2 years ago

Can confirm the above. The camera is added properly in HA. Device events are raised as expected for people and doorbell. Not tested other events, but no reason for it not to work. Suspect the issue with video is Exactly WebRTC vs RSTP. See the below error from my logs:

google_nest_sdm.exceptions.ApiException: Error from API: 400: INVALID_ARGUMENT: Command sdm.devices.commands.CameraLiveStream.GenerateRtspStream not supported.: Bad Request

See this link for an explanation of how the camera feed should work for a battery doorbell: https://developers.google.com/nest/device-access/api/doorbell-battery

allenporter commented 2 years ago

Great! I am not aware that home assistant core has any other web rtc video streams yet, but I know some custom components do it. Will look into this.

@uvjustin as a heads up that the new nest cams don't support rtsp.

allenporter commented 2 years ago

https://github.com/allenporter/python-google-nest-sdm/issues/58 tracks the work in the underlying python library

uvjustin commented 2 years ago

Great! I am not aware that home assistant core has any other web rtc video streams yet, but I know some custom components do it. Will look into this.

@uvjustin as a heads up that the new nest cams don't support rtsp.

Interesting. Not sure how to fit this into the current stream framework though. For viewing, if the webrtc endpoint is reachable externally, the easiest/most performant thing is to just forward the endpoint to the frontend or to a custom card. Otherwise, to get the stream into HA for redistribution via HTTP/casting/saving clips, maybe have a look at aiortc.

thingwithstuff commented 2 years ago

After some wrangling, mine has connected through the Nest integration but is only showing one entity for camera.doorbell and that's it.

allenporter commented 2 years ago

@thingwithstuff great. You only get one entity: https://www.home-assistant.io/integrations/nest/#camera

I assume you are expecting binary sensors to show up for events, but instead see https://www.home-assistant.io/integrations/nest/#automation-and-device-triggers

And of course, we need to add support for video for battery cams since they work totally differently.

thingwithstuff commented 2 years ago

Cool, still learning on the Nest stuff, was comparing it to the relative ease of a Ring setup

On Thu, Sep 23, 2021 at 12:07 PM Allen Porter @.***> wrote:

@thingwithstuff https://github.com/thingwithstuff great. You only get one entity: https://www.home-assistant.io/integrations/nest/#camera

I assume you are expecting binary sensors to show up for events, but instead see https://www.home-assistant.io/integrations/nest/#automation-and-device-triggers

And of course, we need to add support for video for battery cams since they work totally differently.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/55302#issuecomment-925456077, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUUTOYVH6EVPBKR4H2TYDLLUDKDVHANCNFSM5C4KRBBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

kevmang commented 2 years ago

One problem I noticed with the new Nest Doorbell Battery integration aside from the camera feed not working is the status isn't being updated, so none of the device triggers work.

My Nest thermostat correctly updates the current temperature to HA using the Nest API so it shouldn't be a connectivity issue. Can anyone confirm they're having the same issue?

allenporter commented 2 years ago

Hi, nest cameras don't currently use a status at all. If you have a feature request you'd like to see feel free to post in the community forums and we can discuss there.

Nest battery cameras have new features that aren't yet supported. I don't think we need any more data about what folks are experiencing yet.

Travisco29 commented 2 years ago

Can confirm that The doorbell shows up, but there is no sensor for doorbell press.

scottjones4k commented 2 years ago

There is no sensor for doorbell press, but as per the integrations documentation, there are events raised which you can hook up to using device triggers. I currently have this working to send notifications on person detected and doorbell pressed.

allenporter commented 2 years ago

Quick updated: I've started architecture discussions on https://github.com/home-assistant/architecture/discussions/640 for how we might support WebRTC for the battery cams. Consider this a work in progress.

Also, folks, discussions about binary sensors are not relevant. See https://www.home-assistant.io/integrations/nest/#automation-and-device-triggers and feel free to discuss in community forums.

kevmang commented 2 years ago

I'm aware how device triggers work and also the Nest doesn't utilise binary sensors. My issue with the Video Doorbell (Battery) is the device state isn't being updated into HA. The state sits on "idle" regardless of whatever event is supposed to be triggered. Is there something different to the way the Battery version of the doorbell interacts with the Google Nest service compared to the wired one?

allenporter commented 2 years ago

First, battery cams aren't supported yet as stated above multiple times. Second, no nest cams ever set state. The concept doesn't exist in the nest sdm API.

Just to be clear, folks, battery cams don't work yet. We don't need additional detail.

PlinyElderATX commented 2 years ago

Probably worth clarifying that it isn't just the battery cams, the "new" non-battery cams don't work either.

allenporter commented 2 years ago

Thanks didn't realize that distinction. What were tracking here is adding support for webrtc based cams returned from the API. I don't have any other new cams but presumably they conform to the same APIs.

All the PRs are in flight of you want to start testing locally, or will let you know when you can test on a nightly or dev build.

allenporter commented 2 years ago

WebRTC streams should be working in a nightly dev build now if folks want to test it out.

allenporter commented 2 years ago

This is now in the beta. I'm going to close this and will keep making improvements like the image thumbnails, support for video clips, etc.

I believe webrtc support may only work in Chrome at the moment and that needs some diagnosing on other platforms, so expect improvements over time.

allenporter commented 2 years ago

Please file any new issues as you come across, I expect there will be many.

PlinyElderATX commented 2 years ago

Running current beta channel and webrtc camera still not displaying. Are there other changes in should make?

allenporter commented 2 years ago

As I mentioned in my previous update, I was hoping if you run into issues that you'd report it separately https://www.home-assistant.io/help/#bugs-feature-requests-and-alike so we can track down individual problems with their own history. I'd need more information, like a full bug report to help diagnose. Thank you for your help in testing this out!

PlinyElderATX commented 2 years ago

Done: https://github.com/home-assistant/frontend/issues/10446

On Wed, Oct 27, 2021 at 11:05 PM Allen Porter @.***> wrote:

As I mentioned in my previous update, I was hoping if you run into issues that you'd report it separately https://www.home-assistant.io/help/#bugs-feature-requests-and-alike so we can track down individual problems with their own history. I'd need more information, like a full bug report to help diagnose. Thank you for your help in testing this out!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/55302#issuecomment-953462123, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANFJ7VC7GKLQ5IROMIZDDTTUJC4WPANCNFSM5C4KRBBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

allenporter commented 2 years ago

FYI Home Assistant release today contains battery camera support via WebRTC. Feel free to file issues as you come across any.