home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
70.83k stars 29.53k forks source link

OVO Integration pulling through energy values into cost value entity #55575

Closed mark-130 closed 2 years ago

mark-130 commented 2 years ago

The problem

Since updating to 2021.9.0 the OVO energy integration is pulling through the value of the consumed gas/electric in units into the entity that should be displaying the daily cost

What is version of Home Assistant Core has the issue?

2021.9.0

What was the last working version of Home Assistant Core?

2021.8.#

What type of installation are you running?

Home Assistant Core

Integration causing the issue

OVO Energy

Link to integration documentation on our website

https://www.home-assistant.io/integrations/ovo_energy

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No log entries

Additional information

No response

probot-home-assistant[bot] commented 2 years ago

Hey there @timmo001, mind taking a look at this issue as it has been labeled with an integration (ovo_energy) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)


ovo_energy documentation ovo_energy source (message by IssueLinks)

deosrc commented 2 years ago

Had a slight panic with this before I realised what was happening :joy:

Looks like a copy paste error. These 2 lines are identical to the lines for the consumption sensors.

https://github.com/home-assistant/core/blob/dev/homeassistant/components/ovo_energy/sensor.py#L60 https://github.com/home-assistant/core/blob/dev/homeassistant/components/ovo_energy/sensor.py#L94

If the library is just passing through the API response, I think the end of the line is supposed to be ...[-1].cost.amount.

mark-130 commented 2 years ago

Any update on this being fixed?