home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
70.57k stars 29.48k forks source link

USB discovery entries for Z-Wave JS are too generic #55586

Open RicArch97 opened 2 years ago

RicArch97 commented 2 years ago

The problem

in /homeassistant/generated/usb.py there are some entries for VID/PID combo's that identify USB dongles with a specific integration.

For Z-Wave JS this is included in the file:

{
        "domain": "zwave_js",
        "vid": "10C4",
        "pid": "EA60"
}

The VID:10C4 and PID:EA60 belong to a very generic cp210x chipset by Silicon labs. The problem is that all other devices that aren't Z-Wave JS radio's now show up as Z-Wave.

I'm sure this isn't a problem for the current core integrations as Z-Wave JS and ZHA are about the only onces that use USB, but if you'd use any other dongles from a custom integration this will become very confusing for users. Also for future proofing purposes, it might be useful to identify more devices with this chipset within core.

One solution could be to identify based on description (iProduct) too just like ZHA but i'm not sure if those are provided with the Z-Wave sticks.

What is version of Home Assistant Core has the issue?

core-2021.9.0

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

USB Discovery

Link to integration documentation on our website

https://www.home-assistant.io/integrations/usb/

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

2021-09-02T13:49:27,593849507+02:00

^ not a z-wave dongle but is identified as one.

issue-triage-workflows[bot] commented 1 month ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Hedda commented 1 month ago

Questions remains open