Ecovacs integration dependency no longer maintained

clayauld commented 3 years ago

The problem

The ecovacs integration has a dependency called "sucks" (see here: https://github.com/wpietri/sucks). The maintainer has archived the repo and deprecated support.

The proposed solution would be to migrate over to a maintained repo (see here: https://github.com/Ligio/ozmo) and migrate the integration over to something like this custom integration: https://github.com/Ligio/hacc-ozmo

I have confirmed this integration works adequately, and offers extended features

What is version of Home Assistant Core has the issue?

core-2021.10.0

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

ecovacs

Link to integration documentation on our website

https://www.home-assistant.io/integrations/ecovacs/

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

I am working on an update and can create a PR to migrate the integration over to the new backend. This will integrate code from others and will need to go through verification from other users

probot-home-assistant[bot] commented 3 years ago

ecovacs documentation ecovacs source _{^{(message by IssueLinks)}}

probot-home-assistant[bot] commented 3 years ago

Hey there @overloadut, mind taking a look at this issue as it has been labeled with an integration (ecovacs) you are listed as a code owner for? Thanks! _{^{(message by CodeOwnersMention)}}

clayauld commented 3 years ago

Hey there @OverloadUT, I can help support a migration effort for the integration. If you would like help on this please let me know.

edenhaus commented 3 years ago

I support your idea, but when we are putting our hands on this integration, we should also include support for all 3 supported communication protocols:

XMPP (e.g. Slim 2, N79, OZMO 930)
MQTT/XML (e.g. Deebot 900, OZMO 900)
MQTT/JSON (e.g. OZMO 920/950, T8 series and probably all newer models)

I currently maintain https://github.com/And3rsL/Deebot-for-Home-Assistant and the used library https://github.com/And3rsL/Deebotozmo, which support MQTT/JSON protocol.

Currently your suggested library is not supporting at least MQTT/JSON. This means all newer models from the 950 will not be supported. I only have the 950 ozmo, so I cannot test/debug the other protocols. This is also the reason why I cannot integrate the support for the two others on my maintained lib.

The last week i started to get all guys, which contributed on ecovacs things together, so we can document the api and also create one supported integration for all models. At least this was my idea 😊

My suggestion is first create a library, that supports all protocols and then get the hands on the official integration.

As you have written above, you are welcome to contribute your used protocol on https://github.com/And3rsL/Deebotozmo 😊

clayauld commented 3 years ago

Thanks for your response. I definitely agree that supporting all communications protocols is the best path forward.

Given that requirement, who have you engaged to start merging all the efforts for ecovacs-related software? I think it may be best to get @Ligio involved as I am only using their work and have done quite a bit of testing on my Deebot model.

I can provide help as I have time, but much of my effort has been reusing others' work.

edenhaus commented 3 years ago

Currently I started to contact a few of them and getting feedback on my idea. Engaged is the wrong word, as we all are doing this in our freetime it will take time and I also don‘t hurry.

I can provide help as I have time, but much of my effort has been reusing others' work.

I also have a full time job and I study alongside. Creating one library supporting all takes time and also updating the core integration. When we touch the integration, the first thing we need to add is config_flow support and tests for that.

clayauld commented 3 years ago

Gotcha. Yes, I have a full time job and my work is done in my free time. Good code takes time and testing. I'll take a look at your repo and see if I can contribute.

jesse-schein commented 3 years ago

I'd be happy to contribute to make things work, I have a T8+ and have experience creatinghome assistant integrations and libraries.

clayauld commented 3 years ago

It looks like this issue was discussed at ecovacs-abandonware-alert. Can we compile a list of working ecovacs bots and update the documentation in the interim?

It seems that updating the integration docs would be quicker and easier while work on a fix is completed.

home-assistant / core