home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.17k stars 29.85k forks source link

Pentair ScreenLogic integration: Add-on config 'startup' with 'before' is deprecated #60187

Closed TermiNaderTL closed 2 years ago

TermiNaderTL commented 2 years ago

The problem

From the configuration log:

WARNING (MainThread) [supervisor.addons.validate] Add-on config 'startup' with 'before' is deprecated. Please report this to the maintainer of Pentair Screenlogic.

What version of Home Assistant Core has the issue?

2021.11.5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Pentair Screenlogic

Link to integration documentation on our website

https://www.home-assistant.io/integrations/screenlogic

Example YAML snippet

No response

Anything in the logs that might be useful for us?

WARNING (MainThread) [supervisor.addons.validate] Add-on config 'startup' with 'before' is deprecated. Please report this to the maintainer of Pentair Screenlogic.

Additional information

No response

probot-home-assistant[bot] commented 2 years ago

screenlogic documentation screenlogic source (message by IssueLinks)

probot-home-assistant[bot] commented 2 years ago

Hey there @dieselrabbit, mind taking a look at this issue as it has been labeled with an integration (screenlogic) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

dieselrabbit commented 2 years ago

This warning seems like it is for a custom add-on, not an integration.

Do you have a custom Pentair Screenlogic addon installed under the Supervisor menu?

TermiNaderTL commented 2 years ago

No, I only have an integration installed: https://www.home-assistant.io/integrations/screenlogic. Many months ago I migrated from the custom add-on and mqtt to this integration. Could something be "left over" that I need to clean up?

Love the integration, by the way! I just happen to notice it when I went to Supervisor...System and saw the Log Provider: Supervisor.

I just restarted the Supervisor on its own to see if I could get more debug type info. Here are the same messages with some context. Hopefully this helps:

21-11-22 21:27:52 INFO (MainThread) [supervisor.homeassistant.secrets] Loaded 14 Home Assistant secrets 21-11-22 21:27:52 INFO (MainThread) [supervisor.os.manager] Detect Home Assistant Operating System 6.6 / BootSlot A 21-11-22 21:27:53 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'startup' with 'before' is deprecated. Please report this to the maintainer of Pentair Screenlogic 21-11-22 21:27:53 INFO (MainThread) [supervisor.store.git] Loading add-on /data/addons/git/cebe7a76 repository 21-11-22 21:27:53 INFO (MainThread) [supervisor.store.git] Loading add-on /data/addons/git/a0d7b954 repository 21-11-22 21:27:53 INFO (MainThread) [supervisor.store.git] Loading add-on /data/addons/core repository 21-11-22 21:27:56 WARNING (MainThread) [supervisor.addons.validate] Add-on config 'startup' with 'before' is deprecated. Please report this to the maintainer of Pentair Screenlogic 21-11-22 21:27:56 INFO (MainThread) [supervisor.store] Loading add-ons from store: 64 all - 64 new - 0 remove 21-11-22 21:27:56 INFO (MainThread) [supervisor.addons] Found 10 installed add-ons

dieselrabbit commented 2 years ago

It looks like the config option the supervisor is complaining about is an add-on option, and was removed as depreciated in the Screenlogic add-on in https://github.com/bwoodworth/hassio-addons/commit/6f55dcb2793fe3281c4d63dc138c4adb786a538e#diff-045ff474f378b816feeae0d18e38ad65544027a6a8c2dcefcc5dae49eae0add7 so it seems like there might be something "left over" that needs to be cleaned up.

If you simply uninstalled the add-on as normal, there may be something unintentionally left behind that may need to be reported to the Supervisor project.

TermiNaderTL commented 2 years ago

Thanks! Sorry to bother you about this. The integration is amazing!

dieselrabbit commented 2 years ago

No worries. I learned something new today as well.