Closed crlogic closed 2 years ago
sonos documentation sonos source (message by IssueLinks)
Hey there @cgtobi, @jjlawren, mind taking a look at this issue as it has been labeled with an integration (sonos
) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)
I think this may be (unintentionally) fixed by https://github.com/home-assistant/core/pull/62691. The API was inconsistently named and it looks like I used the wrong name in the subscription callback handling method.
Roger that. I'll report back when 12.6 drops.
Merry Christmas!
On Sat, Dec 25, 2021, 10:34 PM jjlawren @.***> wrote:
I think this may be (unintentionally) fixed by #62691 https://github.com/home-assistant/core/pull/62691. The API was inconsistently named and it looks like I used the wrong name in the subscription callback handling method.
— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/62787#issuecomment-1001101860, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASNI46XD7BSR3WECYATNZ3US2ELJANCNFSM5KYNHOBQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
At version 12.6, the speech enhancement is fixed but the night mode is broken
Can you please verify this and provide more info? No changes were made that should impact night mode.
Can confirm Night Sound is now doing the same odd toggle behavior in 12.6 Sometimes it reports the correct state. Other times, it doesn't.
Additionally, after update, Speech Enhancement switch has now duplicated so I have two versions of this switch. The original is unavailable. The _2 versions appears to be working as expected with brief testing. The side effect is that I now need to find/replace previous automations using this switch.
[edit] spelling
At version 12.6, the speech enhancement is fixed but the night mode is broken
Can you please verify this and provide more info? No changes were made that should impact night mode.
Yes confirmed. I had the exact same behavior as crlogic described
Ah, the change that fixed the behavior also creates a duplicate switch. Sorry about that. You can delete the "old" one and rename the new entity as needed.
You can delete the "old" one and rename the new entity as needed.
Roger that. Wasn't sure if that was intended and it would come back at some point.
Should we open a new issue for Night Sound?
[edit] issue created: https://github.com/home-assistant/core/issues/62902
While trying to rush fixes out I introduced a couple new problems. Here are upcoming fixes for those discussed in this issue:
Both of the above fixes are included in 2021.12.7 which should be available imminently.
If you've previously upgraded to 2021.12.6 and have not cleaned up the duplicate switches, you'll see a warning like this in your logs during startup:
Migration of Speech Enhancement switches on <SPEAKER_NAME> failed, manual cleanup required
Once you remove the old duplicate switch the warning will go away. Sorry for the inconvenience.
The problem
On HA 2021.12.5 using the stock Sonos integration with disabled entities (bass/treble/etc), the Speech Enhancement switch does not accurately reflect state in Configuration --> Integrations --> Sonos --> Device (Eg. Beam..)
In the aforementioned GUI location, the Speech Enhancement button always reverts to on or off. This has flip/flopped depending on HA restarts. I suspect that initial HA core boot state influences whether it always reverts to display as on or always reverts to display as off.
I have an automation that turns Speech Enhancement on or off depending on trigger/conditions and that works as advertised. So this anomaly is related to displaying the state and not actual functionality.
Developer Tools --> States --> Entity also shows the incorrect state. Even if an automation has actually set the state as desired.
What version of Home Assistant Core has the issue?
2021.12.5
What was the last working version of Home Assistant Core?
N/A
What type of installation are you running?
Home Assistant OS
Integration causing the issue
Sonos
Link to integration documentation on our website
https://www.home-assistant.io/integrations/sonos/
Example YAML snippet
Anything in the logs that might be useful for us?
Additional information
The Night Sound switch functions as advertised and reflects actual state instantly regardless if triggered by HA GUI button or Sonos app.